refactor: Updated tokens full view to use MMDS components#30916
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit aa7738b. Configure here.
…to select/tokens
Contributor
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: Performance Test Selection: |
Prithpal-Sooriya
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Updates the Tokens full view (“View all tokens”) and shared token control bar to use MMDS (
@metamask/design-system-react-native) and correct safe-area handling.Why
What changed
TokensFullView:SafeAreaView→Box;HeaderBase→HeaderStandardwithincludesTopInset(no custom header styles).BaseControlBar: Network filterButtonBase→SelectButton(primary); network avatar →AvatarNetwork; filter/add icons → MMDSButtonIcon(Md). Removed legacy bordered button styles fromControlBarStyles.TokenListControlBar: Import (+) button uses MMDSButtonIcon(Md), no custom background override.TokenList/Tokens: WhenisFullView, apply bottom safe-area inset aspaddingBottomon scroll content (FlashListcontentContainerStyle; empty-stateScrollViewcontentContainerStyle). Hide vertical scroll indicator on full-view list.px-4); bottom paddingpb-3on control bar; tests updated forSelectButton/AvatarNetwork.Motivation
Design-system migration for the Tokens full view control bar and header, with safer list scrolling above the home indicator on notched devices.
Changelog
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/DSYS-770
Manual testing steps
Also verify (quick):
CashTokensFullView) if you touched sharedBaseControlBar/Tokenspaths used there.Screenshots/Recordings
Before
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2026-06-01.at.22.59.30.mov
After
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2026-06-01.at.22.51.18.mov
Pre-merge author checklist
BaseControlBar.test.tsx,TokensFullView.test.tsx,TokenList/Tokenstests updated or passingPerformance checks (if applicable)
Pre-merge reviewer checklist
Note
Low Risk
UI-only design-system and layout changes with no auth, networking, or asset logic changes; regression risk is limited to Tokens/Cash full-view presentation and scrolling.
Overview
Migrates the Tokens full view (“View all tokens”) to MMDS: custom header/
SafeAreaViewlayout is replaced withHeaderStandard(includesTopInset), and the shared control bar swaps legacy component-library controls forSelectButton(network filter),AvatarNetwork, and MdButtonIconfor sort/add—dropping bespoke bordered button styles fromControlBarStyles.For
isFullViewonly, scroll content now gets bottom safe-areapaddingBottomon theFlashListand empty-stateScrollView, hides the vertical scroll indicator on the list, and tweaks control bar spacing (pb-3).BaseControlBartests are updated for the new components.Reviewed by Cursor Bugbot for commit 45605a0. Bugbot is set up for automated code reviews on this repo. Configure here.