Skip to content

fix(rewards): hypertracker logo color#30891

Merged
sophieqgu merged 1 commit into
mainfrom
Fix-hypertracker-logo
Jun 1, 2026
Merged

fix(rewards): hypertracker logo color#30891
sophieqgu merged 1 commit into
mainfrom
Fix-hypertracker-logo

Conversation

@sophieqgu

@sophieqgu sophieqgu commented Jun 1, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Simulator Screenshot - E2E Test - 2026-06-01 at 14 30 25 Simulator Screenshot - E2E Test - 2026-06-01 at 14 31 03

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Small UI/theming change on the rewards leaderboard with a focused test; no auth, data, or payment logic.

Overview
The HyperTracker wordmark on the perps trading campaign leaderboard no longer stays hard-coded white. The SVG wordmark path now uses currentColor, and PerpsTradingCampaignLeaderboard passes colors.text.default from useTheme into HyperTrackerLogo so the logo matches the active theme (e.g. readable in light mode).

A unit test wraps the leaderboard in ThemeContext and asserts the logo receives the theme text color.

Reviewed by Cursor Bugbot for commit 909d29e. Bugbot is set up for automated code reviews on this repo. Configure here.

@sophieqgu sophieqgu requested a review from a team as a code owner June 1, 2026 18:37
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@mm-token-exchange-service mm-token-exchange-service Bot added the team-rewards Rewards team label Jun 1, 2026
@github-actions github-actions Bot added the size-S label Jun 1, 2026
@sophieqgu sophieqgu enabled auto-merge June 1, 2026 18:38
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokePerps, SmokeWalletPlatform, SmokeConfirmations
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are limited to:

  1. PerpsTradingCampaignLeaderboard.tsx - A new/modified UI component for the Perps Trading Campaign Leaderboard. It renders leaderboard entries, handles split-view for users outside the top ranks, and includes a HyperTracker attribution logo that navigates to the in-app browser.
  2. PerpsTradingCampaignLeaderboard.test.tsx - Unit tests for the component (no E2E impact).
  3. hypertracker.svg - A new SVG asset used in the leaderboard component.

Tag selection reasoning:

  • SmokePerps: Directly affected - this is a core perps trading campaign leaderboard component used in PerpsTradingCampaignLeaderboardView, PerpsTradingCampaignDetailsView, PerpsTradingCampaignWinningView, and PerpsTradingCampaignStatsView.
  • SmokeWalletPlatform: Required per SmokePerps tag description - Perps is a section inside the Trending tab, so changes to Perps views affect Trending/SmokeWalletPlatform.
  • SmokeConfirmations: Required per SmokePerps tag description - Add Funds deposits are on-chain transactions that go through confirmations.
  • SmokeBrowser was considered since the HyperTracker logo press navigates to the in-app browser, but this is a minor navigation call (navigate to browser home) that doesn't change browser infrastructure itself. The browser navigation is a standard pattern used throughout the app and doesn't warrant running the full SmokeBrowser suite for this minor addition.

Risk is low as these are isolated UI component changes within the Perps campaign feature with no changes to core controllers, navigation infrastructure, or shared components.

Performance Test Selection:
No performance-critical changes. The modifications are limited to a UI component (leaderboard display) and a new SVG asset. There are no changes to data loading, state management, list rendering performance, or any core flows that would impact app performance metrics.

View GitHub Actions results

@github-actions github-actions Bot added the risk:low AI analysis: low risk label Jun 1, 2026
cursor[bot]
cursor Bot reviewed Jun 1, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 909d29e. Configure here.

Comment thread app/components/UI/Rewards/components/Campaigns/PerpsTradingCampaignLeaderboard.test.tsx
@sophieqgu sophieqgu added this pull request to the merge queue Jun 1, 2026
Merged via the queue into main with commit 23581ce Jun 1, 2026
215 of 217 checks passed
@sophieqgu sophieqgu deleted the Fix-hypertracker-logo branch June 1, 2026 20:31
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 1, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.81.0 Issue or pull request that will be included in release 7.81.0 label Jun 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@Montoya Montoya Montoya approved these changes

Assignees

No one assigned

Labels

release-7.81.0 Issue or pull request that will be included in release 7.81.0 risk:low AI analysis: low risk size-S team-rewards Rewards team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sophieqgu @Montoya