feat: add ARC mainnet support#30879
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
58d9f6e to
0195180
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
14528e4 to
207a4db
Compare
43dbcc1 to
f073996
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f073996. Configure here.
| MNT: MANTLE_NATIVE, | ||
| USD: TEMPO_NATIVE, | ||
| PATHUSD: TEMPO_NATIVE, | ||
| USDC: ARC_NATIVE, |
There was a problem hiding this comment.
USDC icon applies all chains
Medium Severity
Mapping USDC to the Arc native asset image in the shared image-icons map makes every token whose symbol is USDC use that bundled artwork, on every network. TokenIcon and bridge helpers resolve icons by symbol only and pick the local map before any remote icon URL, so ERC-20 USDC on Ethereum, Base, Polygon, and elsewhere can show the wrong branding instead of the usual USDC artwork.
Reviewed by Cursor Bugbot for commit f073996. Configure here.
There was a problem hiding this comment.
Reviewers: This was not exactly intended to affect other networks. However I can see it as a positive side effect - if anything. What do you think ?
|
@metamaskbot publish-preview |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #30879 +/- ##
==========================================
+ Coverage 82.86% 82.99% +0.13%
==========================================
Files 5582 5584 +2
Lines 144198 143830 -368
Branches 33521 33425 -96
==========================================
- Hits 119483 119368 -115
+ Misses 16682 16438 -244
+ Partials 8033 8024 -9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
f073996 to
c688690
Compare
|
@metamaskbot publish-preview |
6343864 to
0917db7
Compare
0917db7 to
0829949
Compare
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: Performance Test Selection: |
Base Enablement + Popular Network listing for Arc.
⚠️
QUICKNODE_ARC_URLsecret needs to be set when merging this PR - added to the repository settings but usure if more needs to be done.Description
Changelog
CHANGELOG entry: add Arc as Default Network (network/native logo + native price + multicall)
Related issues
Fixes:
Manual testing steps
0xbEf5f6d51CB62b58e6A8f77868681825C6fe21c10xd2a530170D71a9Cfe1651Fb468E2B98F7Ed7456b0x171A4217b86A807A64eB94757Db6849fb4bDbAA0USDCas native asset - price for other tokens will appear later as they get discovered by the Price API (subject to Coingecko support).Screenshots/Recordings
Before
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Low Risk
Standard new-chain enablement with config, images, and dependency bumps; operational risk is mainly ensuring
QUICKNODE_ARC_URLis set so failover RPC works.Overview
Adds Arc mainnet (chain
5042/0x13b2) as a default, Popular network with USDC as the native currency symbol and dedicated network/token artwork.Wiring includes Infura primary RPC (
arc-mainnet), QuickNode failover via newQUICKNODE_ARC_URL(also listed inbuilds.yml), explorerexplorer.arc.io, and chain ID / currency mappings inapp/constants/network.js. Tests were updated for the popular-network list and QuickNode env setup.Dependency bumps:
@metamask/assets-controllers108.4.0 and@metamask/network-enablement-controller5.3.0 (with lockfile updates). Merge note:QUICKNODE_ARC_URLmust be present in CI/build secrets for failover RPC to work in production builds.Reviewed by Cursor Bugbot for commit 0829949. Bugbot is set up for automated code reviews on this repo. Configure here.