Skip to content

feat(predict): add compact World Cup banner cp-7.80.0#30874

Merged
matallui merged 5 commits into
mainfrom
predict/pred-939
Jun 2, 2026
Merged

feat(predict): add compact World Cup banner cp-7.80.0#30874
matallui merged 5 commits into
mainfrom
predict/pred-939

Conversation

@matallui

@matallui matallui commented Jun 1, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Adds a compact variant for PredictWorldCupMainFeedBanner so the Predict feed header uses less vertical space and leaves more room for the scrollable content area.

This keeps the existing full-size banner layout available as the default variant, while switching the Predict feed usage to variant="compact". It also adds the compact World Cup banner image asset from Figma alongside the existing banner asset.

Changelog

CHANGELOG entry: null

Related issues

Fixes: PRED-939

Manual testing steps

Feature: Compact Predict World Cup banner

  Scenario: user views the Predict feed World Cup banner
    Given the Predict World Cup feature flag enables the main feed banner

    When user opens the Predict feed
    Then the World Cup banner is shown in the compact horizontal layout
    And more vertical space is available for the scrollable market content

Automated test run:

yarn jest app/components/UI/Predict/components/PredictWorldCupMainFeedBanner/PredictWorldCupMainFeedBanner.test.tsx --coverage=false --runInBand --verbose

Screenshots/Recordings

Before

Simulator Screenshot - mm-blue - 2026-05-28 at 11 44 57

After

Simulator Screenshot - mm-blue - 2026-06-01 at 09 38 27

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
UI-only Predict banner layout and asset selection; no auth, payments, or data-handling changes.

Overview
Adds a compact layout option to PredictWorldCupMainFeedBanner: horizontal row with an 80×80 thumbnail and a dedicated compact fallback asset, while default keeps the full-width banner behavior.

PredictFeed now passes variant="compact" so the feed header uses less vertical space for market lists. Tests assert compact image dimensions.

Reviewed by Cursor Bugbot for commit be9fe6f. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label Jun 1, 2026
@mm-token-exchange-service mm-token-exchange-service Bot added the team-predict Predict team label Jun 1, 2026
@github-actions github-actions Bot added the size-S label Jun 1, 2026
@matallui matallui marked this pull request as ready for review June 1, 2026 15:57
@matallui matallui requested a review from a team as a code owner June 1, 2026 15:57
@matallui matallui removed the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label Jun 1, 2026
@github-actions github-actions Bot added the risk:low AI analysis: low risk label Jun 1, 2026
@matallui matallui changed the title feat: add compact World Cup banner feat(predict): add compact World Cup banner cp-7.80.0 Jun 1, 2026
@matallui matallui enabled auto-merge June 1, 2026 17:30
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokePredictions, SmokeWalletPlatform, SmokeConfirmations
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are limited to the Predictions feature UI:

  1. PredictWorldCupMainFeedBanner.tsx: Added a variant prop ('default' | 'compact') to support a compact layout with a new 80x80 image asset. The compact variant uses a row layout with different image sizing and styling.
  2. PredictFeed.tsx: Updated to pass variant="compact" to the banner in the AnimatedHeader, changing how the World Cup banner renders in the Predictions feed.
  3. New image asset: world-cup-main-feed-banner-compact.png added for the compact variant.
  4. Unit test: Added test coverage for the compact variant dimensions.

Tag selection rationale:

  • SmokePredictions: Directly affected — the PredictFeed (Predictions main view) now renders the banner in compact mode. E2E tests for Predictions should validate the feed renders correctly.
  • SmokeWalletPlatform: Required per tag description — Predictions is a section inside the Trending tab. Changes to Predictions views affect Trending, which is tested under SmokeWalletPlatform.
  • SmokeConfirmations: Required per SmokePredictions tag description — opening/closing positions are on-chain transactions that go through confirmations.

No changes to core infrastructure, controllers, navigation, or shared components. Risk is low as this is a UI-only change to a specific feature component.

Performance Test Selection:
The changes are purely UI/visual — adding a compact variant to a banner component with a new image asset. No changes to data loading, state management, list rendering performance, or app initialization. No performance tests are warranted.

View GitHub Actions results

@matallui matallui added the skip-e2e skip E2E test jobs label Jun 2, 2026
@matallui

matallui commented Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

Skipping e2e tests since wallet-platform-android-smoke-1 is not passing but it is unrelated to this PR. Issue happening across multiple PRs.

@matallui matallui added this pull request to the merge queue Jun 2, 2026
Merged via the queue into main with commit e2e786c Jun 2, 2026
150 of 155 checks passed
@matallui matallui deleted the predict/pred-939 branch June 2, 2026 03:43
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 2, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.81.0 Issue or pull request that will be included in release 7.81.0 label Jun 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@caieu caieu caieu approved these changes

Assignees

No one assigned

Labels

release-7.81.0 Issue or pull request that will be included in release 7.81.0 risk:low AI analysis: low risk size-S skip-e2e skip E2E test jobs team-predict Predict team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matallui @caieu