chore(runway): cherry-pick fix(engagement): latch startup marketing consent prompt cp-7.80.0#30827
Merged
runway-github[bot] merged 2 commits intoJun 1, 2026
Conversation
…onsent prompt (#30808) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until this PR meets the canonical Definition of Ready For Review in `docs/readme/ready-for-review.md`. In short: the template must be materially complete (not just section titles present), all status checks must be currently passing, and the only expected follow-up commits must be reviewer-driven. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Fixes an issue where the marketing_consent notification pre-prompt could be re-triggered during the same app session after the user turned marketing consent off in Settings. The pre-prompt is intended to behave as a startup flow. This change latches the marketing consent value used for startup prompt resolution, so once startup eligibility has resolved, later Redux updates from user actions do not cause the prompt to appear unexpectedly. Social-login marketing consent backfill is still respected as part of startup resolution. If backfill is pending, the prompt waits for it to clear, then decides once using the resolved consent value. Risk Low risk. This change is scoped to usePushPrePromptVariant, which only decides which notification pre-prompt variant to show. It does not change notification registration, OS permission requests, Settings behavior, analytics opt-in/out behavior, or persisted storage keys. The change preserves existing behavior for the main paths: Users without OS push permission still resolve to the push permission prompt first. Users who already saw the pre-prompt remain suppressed by PUSH_PRE_PROMPT_SHOWN. Users with marketing consent enabled do not see the marketing consent prompt. Users with marketing consent disabled at startup can still see the one-time startup prompt if otherwise eligible. Social-login users still wait for marketing consent backfill before the marketing prompt decision is made. The risk is low because the fix narrows when the marketing consent prompt can appear rather than expanding eligibility. The only behavior removed is the unintended mid-session re-trigger after Settings opt-out. ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Fixed an issue where the marketing consent notification pre-prompt could reappear after turning marketing consent off in Settings. ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** <!-- Every checklist item must be consciously assessed before marking this PR as "Ready for review". A checked box means you deliberately considered that responsibility, not that you literally performed every action listed. Unchecked boxes are ambiguous: they are not an implicit "N/A" and they are not a silent "skip". See `docs/readme/ready-for-review.md` for the full checklist semantics. --> - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [ ] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [ ] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [ ] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** <!-- Reviewer checklist items follow the same semantics as the author checklist: an unchecked box is ambiguous, a checked box means the reviewer consciously assessed that responsibility. See `docs/readme/ready-for-review.md`. --> - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
vpintorico
approved these changes
Jun 1, 2026
Montoya
approved these changes
Jun 1, 2026
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - PR targets a release or stable branch (release/* or stable) All E2E tests pre-selected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where the marketing_consent notification pre-prompt could
be re-triggered during the same app session after the user turned
marketing consent off in Settings.
The pre-prompt is intended to behave as a startup flow. This change
latches the marketing consent value used for startup prompt resolution,
so once startup eligibility has resolved, later Redux updates from user
actions do not cause the prompt to appear unexpectedly.
Social-login marketing consent backfill is still respected as part of
startup resolution. If backfill is pending, the prompt waits for it to
clear, then decides once using the resolved consent value.
Risk
Low risk.
This change is scoped to usePushPrePromptVariant, which only decides
which notification pre-prompt variant to show. It does not change
notification registration, OS permission requests, Settings behavior,
analytics opt-in/out behavior, or persisted storage keys.
The change preserves existing behavior for the main paths:
Users without OS push permission still resolve to the push permission
prompt first.
Users who already saw the pre-prompt remain suppressed by
PUSH_PRE_PROMPT_SHOWN.
Users with marketing consent enabled do not see the marketing consent
prompt.
Users with marketing consent disabled at startup can still see the
one-time startup prompt if otherwise eligible.
Social-login users still wait for marketing consent backfill before the
marketing prompt decision is made.
The risk is low because the fix narrows when the marketing consent
prompt can appear rather than expanding eligibility. The only behavior
removed is the unintended mid-session re-trigger after Settings opt-out.
Changelog
CHANGELOG entry: Fixed an issue where the marketing consent notification
pre-prompt could reappear after turning marketing consent off in
Settings.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Performance checks (if applicable)
SRPs
to import wallets with many accounts and tokens
performance metrics
trace()for usage andaddTokenfor an example
For performance guidelines and tooling, see the Performance
Guide.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots. ae601d9