feat(onboarding): TMCU-792 interest questionnaire 2-column grid#30753
Merged
Conversation
- Refactor options into a stable 50% column layout with 8px gutters - Add top-right selection indicator; keep existing option PNG assets - Update en copy (crypto tokens, trade perpetuals); keep advanced_trades id - Temporary __DEV__ eligibility threshold for local QA (TODO remove before rollout)
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f0feea3. Configure here.
Add testID and replace toBeTruthy() snapshot checks with getByTestId assertions per unit testing guidelines.
Contributor
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: Performance Test Selection: |
vinnyhoward
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Updates the onboarding interest questionnaire (“What do you want to do with MetaMask?”) to match the TMCU-792 design refresh:
app/images/.en.json: “Buy and sell crypto tokens” and “Trade perpetuals” (advanced_tradesid unchanged for analytics).onComplete()directly (crypto experience screen is TMCU-833, separate PR).Changelog
CHANGELOG entry: Updated the onboarding interest questionnaire layout to a two-column grid with refreshed option labels.
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/TMCU-792
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Low Risk
Onboarding UI and copy only; selection analytics and Continue flow are unchanged aside from layout.
Overview
Refreshes the onboarding interest questionnaire to a two-column card grid (8px gutters) instead of full-width list rows. Each option is a fixed-height card with the illustration and label repositioned and a new top-right selection indicator (
InterestSelectionIndicator).English copy updates two labels: Buy and sell crypto tokens and Trade perpetuals (option ids unchanged for analytics). Continue still only invokes
onComplete()—tests now assert it does not call navigation.Adds unit tests for the indicator and extends questionnaire tests for the grid layout, i18n strings, and continue behavior.
Reviewed by Cursor Bugbot for commit ecf523e. Bugbot is set up for automated code reviews on this repo. Configure here.