Skip to content

chore(rewards): rename Perps competition CTA to "Trade now" (RWDS-1335) cp-7.79.0#30740

Merged
VGR-GIT merged 1 commit into
mainfrom
chore/rwds-1335-trade-now-cta
May 28, 2026
Merged

chore(rewards): rename Perps competition CTA to "Trade now" (RWDS-1335) cp-7.79.0#30740
VGR-GIT merged 1 commit into
mainfrom
chore/rwds-1335-trade-now-cta

Conversation

@VGR-GIT

@VGR-GIT VGR-GIT commented May 28, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Replaces the "Open Position" copy on the Perps Trading Competition opted-in CTA with "Trade now", per RWDS-1335.

Scope is intentionally copy-only:

  • locales/languages/en.json — rewards.perps_trading_campaign.open_position_cta value.
  • app/components/UI/Rewards/components/Campaigns/PerpsTradingCampaignCTA.tsx — comment updated to match.
  • app/components/UI/Rewards/components/Campaigns/PerpsTradingCampaignCTA.test.tsx — mock value, test name, and rendered-text assertion.

No behavior, navigation, or analytics changes — the CTA still deep-links to link.metamask.io/perps?screen=market-list.

Changelog

CHANGELOG entry: null

Related issues

Fixes: RWDS-1335

Manual testing steps

Feature: Perps Trading Competition CTA copy

  Scenario: Opted-in user sees the renamed CTA
    Given I am opted in to the Perps Trading Competition campaign
    And the campaign is active
    When I open the Rewards campaigns view
    Then the campaign CTA reads "Trade now"
    And tapping it deep-links to the Perps market list

Screenshots/Recordings

Before

CTA: "Open Position"

After

CTA: "Trade now"

Pre-merge author checklist

  • I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
  • I've completed the PR template to the best of my ability
  • I've included tests if applicable
  • I've documented my code using JSDoc format if applicable
  • I've applied the right labels on the PR

Note

Low Risk
Copy-only change to an existing i18n string and tests; navigation and campaign logic are unchanged.

Overview
Renames the opted-in Perps Trading Competition primary CTA label from "Open Position" to "Trade now" via rewards.perps_trading_campaign.open_position_cta in English (en.json). The component still uses the same i18n key and handleOpenPosition still deep-links to link.metamask.io/perps?screen=market-list; only the displayed string and an inline comment change. Unit tests update the i18n mock, test description, and on-screen text assertion to match.

Reviewed by Cursor Bugbot for commit a5c865b. Bugbot is set up for automated code reviews on this repo. Configure here.

@VGR-GIT @claude
chore(rewards): rename Perps competition CTA to "Trade now"
a5c865b 
RWDS-1335 — replace "Open Position" copy on the Perps Trading Competition
opted-in CTA with "Trade now". Updates the en.json string, the component
comment, and the matching test mock + assertion.

Co-authored-by: VGR-GIT <vangulckrik@gmail.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions

github-actions Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added team-rewards Rewards team INVALID-PR-TEMPLATE PR's body doesn't match template labels May 28, 2026
@github-actions

github-actions Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 97%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes in this PR are extremely minimal and low-risk:

  1. PerpsTradingCampaignCTA.tsx: Only a code comment was changed ("Open Position" → "Trade now") — no functional logic was modified.
  2. PerpsTradingCampaignCTA.test.tsx: Unit test strings updated to match the new label "Trade now" — purely a test maintenance change.
  3. locales/languages/en.json: A single localization string rewards.perps_trading_campaign.open_position_cta was renamed from "Open Position" to "Trade now".

This is a pure UI text/label rename with no behavioral changes, no logic changes, no API changes, and no navigation changes. No E2E tests reference this string or the PerpsTradingCampaignCTA component directly. The change is fully self-contained within the Rewards/Campaigns component and its unit test. Running E2E tests would provide no additional validation value for this change.

Performance Test Selection:
This is a pure text label change (button text from 'Open Position' to 'Trade now'). There is no performance impact from renaming a localization string. No performance tests are warranted.

View GitHub Actions results

@VGR-GIT VGR-GIT marked this pull request as ready for review May 28, 2026 12:19
@VGR-GIT VGR-GIT requested a review from a team as a code owner May 28, 2026 12:19
@VGR-GIT VGR-GIT enabled auto-merge May 28, 2026 12:19
@Montoya Montoya changed the title chore(rewards): rename Perps competition CTA to "Trade now" (RWDS-1335) chore(rewards): rename Perps competition CTA to "Trade now" (RWDS-1335) cp-7.79.0 May 28, 2026
@sonarqubecloud

sonarqubecloud Bot commented May 28, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@VGR-GIT VGR-GIT added this pull request to the merge queue May 28, 2026
Merged via the queue into main with commit 22e2192 May 28, 2026
216 of 257 checks passed
@VGR-GIT VGR-GIT deleted the chore/rwds-1335-trade-now-cta branch May 28, 2026 12:51
@github-actions github-actions Bot locked and limited conversation to collaborators May 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Montoya Montoya Montoya approved these changes

Assignees

No one assigned

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template size-XS team-rewards Rewards team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@VGR-GIT @Montoya