Skip to content

chore(runway): cherry-pick fix(Rewards): Ondo campaign UX cp-7.79.0#30715

Merged
joaoloureirop merged 1 commit into
release/7.79.0from
runway-cherry-pick-7.79.0-1779921866
May 28, 2026
Merged

chore(runway): cherry-pick fix(Rewards): Ondo campaign UX cp-7.79.0#30715
joaoloureirop merged 1 commit into
release/7.79.0from
runway-cherry-pick-7.79.0-1779921866

Conversation

@runway-github

@runway-github runway-github Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

Description

This attempts to fix what was intended to be fixed in PR #30419 but for
some reason that PR did not work - to ensure that a source token is used
when opening an Ondo swap from Rewards. It also updates the button text
to say "Trade now" instead of "Open Position."

Changelog

CHANGELOG entry: null

Related issues

Fixes: n/a

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
  • Use these power-user
    SRPs

    to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production
    performance metrics
  • See trace() for usage and
    addToken
    for an example

For performance guidelines and tooling, see the Performance
Guide
.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Low Risk
Copy and Rewards swap prefill logic only; changes are localized with
new unit tests and no auth or payment impact.

Overview
Renames the opted-in, no-positions Ondo campaign CTA from Open
Position
to Trade now via rewards.campaign_details.open_position
in en.json, with matching test and comment updates.

Fixes open position swaps from Rewards by resolving default source
tokens through a new getOndoOpenPositionSourceToken helper: chain
defaults are keyed by hex (0x1 → USDC, 0x38 → USDT) instead of
CAIP-only map lookups, and the helper accepts hex or eip155: chain IDs
(including after-hours confirm). USDY balance preference is unchanged;
tests cover BNB/USDT and the helper edge cases.

Reviewed by Cursor Bugbot for commit
be88b88. Bugbot is set up for automated
code reviews on this repo. Configure
here.

[f7e1cce](https://github.com/MetaMask/metamask-mobile/commit/f7e1cce627a4dfde8edeb16e869a4b677c4fff3e)

…30711)

<!--
Please submit this PR as a draft initially.

Do not mark it as "Ready for review" until this PR meets the canonical
Definition of Ready For Review in `docs/readme/ready-for-review.md`.

In short: the template must be materially complete (not just section
titles
present), all status checks must be currently passing, and the only
expected
follow-up commits must be reviewer-driven.
-->

## **Description**

This attempts to fix what was intended to be fixed in PR #30419 but for
some reason that PR did not work - to ensure that a source token is used
when opening an Ondo swap from Rewards. It also updates the button text
to say "Trade now" instead of "Open Position."

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes: n/a

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

<!--
Every checklist item must be consciously assessed before marking this PR
as
"Ready for review". A checked box means you deliberately considered that
responsibility, not that you literally performed every action listed.

Unchecked boxes are ambiguous: they are not an implicit "N/A" and they
are not
a silent "skip". See `docs/readme/ready-for-review.md` for the full
checklist
semantics.
-->

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

#### Performance checks (if applicable)

- [ ] I've tested on Android
  - Ideally on a mid-range device; emulator is acceptable
- [ ] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example

For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).

## **Pre-merge reviewer checklist**

<!--
Reviewer checklist items follow the same semantics as the author
checklist: an
unchecked box is ambiguous, a checked box means the reviewer consciously
assessed that responsibility. See `docs/readme/ready-for-review.md`.
-->

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Copy and Rewards swap prefill logic only; changes are localized with
new unit tests and no auth or payment impact.
> 
> **Overview**
> Renames the opted-in, no-positions Ondo campaign CTA from **Open
Position** to **Trade now** via `rewards.campaign_details.open_position`
in `en.json`, with matching test and comment updates.
> 
> Fixes **open position** swaps from Rewards by resolving default source
tokens through a new `getOndoOpenPositionSourceToken` helper: chain
defaults are keyed by hex (`0x1` → USDC, `0x38` → USDT) instead of
CAIP-only map lookups, and the helper accepts hex or `eip155:` chain IDs
(including after-hours confirm). USDY balance preference is unchanged;
tests cover BNB/USDT and the helper edge cases.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
be88b88. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@runway-github runway-github Bot requested a review from a team as a code owner May 27, 2026 22:44
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label May 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - PR targets a release or stable branch (release/* or stable)

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@joaoloureirop joaoloureirop enabled auto-merge (squash) May 28, 2026 07:43
@joaoloureirop joaoloureirop merged commit de15c5b into release/7.79.0 May 28, 2026
210 checks passed
@joaoloureirop joaoloureirop deleted the runway-cherry-pick-7.79.0-1779921866 branch May 28, 2026 07:43
@github-actions github-actions Bot locked and limited conversation to collaborators May 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size-S team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants