Skip to content

chore: 7702 support money account keyring#30668

Merged
MoMannn merged 1 commit into
mainfrom
chore--enable-money-account-7702-upgrade
May 27, 2026
Merged

chore: 7702 support money account keyring#30668
MoMannn merged 1 commit into
mainfrom
chore--enable-money-account-7702-upgrade

Conversation

@MoMannn

@MoMannn MoMannn commented May 27, 2026

Copy link
Copy Markdown
Member

Description

Enables money account keyring to be 7702 upgradeable.

Changelog

CHANGELOG entry: null

Related issues

Already enabled in core: MetaMask/core#8687

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Small allowlist and enum addition with a unit test; no auth, payment, or broad transaction-path changes.

Overview
Treats Money Keyring accounts as EIP-7702–capable in mobile, matching core support for money-account smart-account upgrades.

Adds ExtendedKeyringTypes.money and includes it in KEYRING_TYPES_SUPPORTING_7702 so accountSupports7702 returns true for money accounts (same as HD and simple keyrings). A unit test locks in that behavior.

Reviewed by Cursor Bugbot for commit 6124cb1. Bugbot is set up for automated code reviews on this repo. Configure here.

@metamaskbotv2 metamaskbotv2 Bot added team-delegation MetaMask Delegation Team INVALID-PR-TEMPLATE PR's body doesn't match template labels May 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeMoney, SmokeConfirmations
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are narrowly scoped to:

  1. Adding a new money = 'Money Keyring' entry to the ExtendedKeyringTypes enum in app/constants/keyringTypes.ts.
  2. Adding ExtendedKeyringTypes.money to the KEYRING_TYPES_SUPPORTING_7702 list in account-supports-7702.ts, enabling EIP-7702 (Setup Smart Account / gas fee token) support for Money keyring accounts.
  3. A corresponding unit test.

SmokeMoney: Directly relevant — the new Money Keyring type is clearly tied to the MetaMask Card/Money product. This change enables EIP-7702 features for Money keyring accounts, which could affect card-related transaction flows.

SmokeConfirmations: The accountSupports7702 function is used in transaction controller initialization to gate EIP-7702 features (batch transactions, gas fee token payments). SmokeConfirmations explicitly tests EIP-7702 account abstraction features. Enabling EIP-7702 for a new keyring type could affect confirmation UI behavior for Money keyring accounts.

No other areas are impacted — there are no changes to UI components, navigation, core Engine initialization, account management, or network handling that would warrant broader test coverage. The keyringTypes.ts file is imported by many files, but the change is purely additive (new enum value) and only the account-supports-7702.ts file uses the new money value.

Performance Test Selection:
The changes are purely additive — adding a new enum value and including it in a small array check. There are no UI rendering changes, no new data loading paths, no state management changes, and no impact on app startup or critical user flow performance. No performance tests are warranted.

View GitHub Actions results

@MoMannn MoMannn marked this pull request as ready for review May 27, 2026 09:05
@MoMannn MoMannn requested a review from a team as a code owner May 27, 2026 09:05
@sonarqubecloud

Copy link
Copy Markdown

@MoMannn MoMannn enabled auto-merge May 27, 2026 10:06
@MoMannn MoMannn added this pull request to the merge queue May 27, 2026
Merged via the queue into main with commit 5998dcc May 27, 2026
241 of 266 checks passed
@MoMannn MoMannn deleted the chore--enable-money-account-7702-upgrade branch May 27, 2026 10:28
@github-actions github-actions Bot locked and limited conversation to collaborators May 27, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.80.0 Issue or pull request that will be included in release 7.80.0 label May 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-7.80.0 Issue or pull request that will be included in release 7.80.0 size-S team-delegation MetaMask Delegation Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants