chore(runway): cherry-pick fix: fix app crash importing ledger cp-7.79.0#30664
Merged
Merged
Conversation
…9.0 (#30522) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until this PR meets the canonical Definition of Ready For Review in `docs/readme/ready-for-review.md`. In short: the template must be materially complete (not just section titles present), all status checks must be currently passing, and the only expected follow-up commits must be reviewer-driven. --> ## **Description** Patch react-native-ble-plx to guard against null reject codes in SafePromise.java. When BLE operations fail with a null error code, React Native's @nonnull promise reject path throws a native NullPointerException, crashing the app during Ledger connect or Select Account pagination on Android. Substitutes a stable fallback code (BleError) while preserving the existing error message payload. Fixes #30491 The proper fix will require update the react-native-ble-plx library in accounts repo. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Patch react-native-ble-plx to prevent nullPointerException throw from native code to crash the app. ## **Related issues** Fixes: #30491 ## **Manual testing steps** Test plan On Android (e.g. Samsung Galaxy S22, Android 16), add a hardware wallet account via Ledger Verify the app does not crash when connecting Ledger Verify pagination in the Select Account interface works without crashing Verify selecting an account completes successfully Smoke test other BLE flows (if applicable) to confirm no regressions ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** <!-- Every checklist item must be consciously assessed before marking this PR as "Ready for review". A checked box means you deliberately considered that responsibility, not that you literally performed every action listed. Unchecked boxes are ambiguous: they are not an implicit "N/A" and they are not a silent "skip". See `docs/readme/ready-for-review.md` for the full checklist semantics. --> - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [x] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [x] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [x] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** <!-- Reviewer checklist items follow the same semantics as the author checklist: an unchecked box is ambiguous, a checked box means the reviewer consciously assessed that responsibility. See `docs/readme/ready-for-review.md`. --> - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Small, localized native guard in a vendored BLE dependency; low blast radius beyond BLE error handling on Android. > > **Overview** > Adds a **Yarn patch** for `react-native-ble-plx@3.4.0` so Android no longer hard-crashes when BLE promise rejections use a **null** error code. > > The patch updates `SafePromise.java` to route all `reject` overloads through `safeCode()`, substituting **`BleError`** when the code is null while keeping the original message (and throwable) intact. **`package.json`** resolutions/dependencies and **`yarn.lock`** now resolve the dependency to the patched artifact instead of plain `3.4.0`. > > This targets Ledger connect / Select Account pagination failures on Android where React Native’s `@NonNull` reject path would otherwise throw a native `NullPointerException`. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit c20f067. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - PR targets a release or stable branch (release/* or stable) All E2E tests pre-selected. |
|
vpintorico
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Patch react-native-ble-plx to guard against null reject codes in
SafePromise.java. When BLE operations fail with a null error code, React
Native's @nonnull promise reject path throws a native
NullPointerException, crashing the app during Ledger connect or Select
Account pagination on Android.
Substitutes a stable fallback code (BleError) while preserving the
existing error message payload.
Fixes #30491
The proper fix will require update the react-native-ble-plx library in
accounts repo.
Changelog
CHANGELOG entry: Patch react-native-ble-plx to prevent
nullPointerException throw from native code to crash the app.
Related issues
Fixes: #30491
Manual testing steps
Test plan
On Android (e.g. Samsung Galaxy S22, Android 16), add a hardware wallet
account via Ledger
Verify the app does not crash when connecting Ledger
Verify pagination in the Select Account interface works without crashing
Verify selecting an account completes successfully
Smoke test other BLE flows (if applicable) to confirm no regressions
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Performance checks (if applicable)
SRPs
to import wallets with many accounts and tokens
performance metrics
trace()for usage andaddTokenfor an example
For performance guidelines and tooling, see the Performance
Guide.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Low Risk
Small, localized native guard in a vendored BLE dependency; low blast
radius beyond BLE error handling on Android.
Overview
Adds a Yarn patch for
react-native-ble-plx@3.4.0so Android nolonger hard-crashes when BLE promise rejections use a null error
code.
The patch updates
SafePromise.javato route allrejectoverloadsthrough
safeCode(), substitutingBleErrorwhen the code is nullwhile keeping the original message (and throwable) intact.
package.jsonresolutions/dependencies andyarn.locknowresolve the dependency to the patched artifact instead of plain
3.4.0.This targets Ledger connect / Select Account pagination failures on
Android where React Native’s
@NonNullreject path would otherwisethrow a native
NullPointerException.Reviewed by Cursor Bugbot for commit
c20f067. Bugbot is set up for automated
code reviews on this repo. Configure
here.