Skip to content

fix: explore search shows count on loading state cp-7.79.0#30618

Merged
juanmigdr merged 3 commits into
mainfrom
fix/explore-search-shows-count
May 26, 2026
Merged

fix: explore search shows count on loading state cp-7.79.0#30618
juanmigdr merged 3 commits into
mainfrom
fix/explore-search-shows-count

Conversation

@juanmigdr

@juanmigdr juanmigdr commented May 26, 2026

Copy link
Copy Markdown
Member

Description

Fix explore search shows count on loading state

Changelog

CHANGELOG entry: fix explore search shows count on loading state

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-3266

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
UI-only label logic in explore search with unit tests; no auth, data, or API behavior changes.

Overview
Fixes explore search section headers showing a “View X more” count while results are still loading.

ExploreSearchResultsV2 now computes the view-more label with zero visible items and no server total when section.isLoading is true, so counts from the previous query are not reused alongside skeleton rows. The label and accessibility text share one computed viewMoreLabel. Tests lock in that all feed types get trending.view_all for that loading input.

Reviewed by Cursor Bugbot for commit 353964d. Bugbot is set up for automated code reviews on this repo. Configure here.

@juanmigdr juanmigdr changed the title fix: explore search shows count on loading state fix: explore search shows count on loading state cp-7.79.0 May 26, 2026
@github-actions github-actions Bot added size-S and removed size-XS labels May 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeWalletPlatform
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are confined to the TrendingView search area:

  1. ExploreSearchResultsV2.tsx: Refactors renderSectionHeader to extract viewMoreLabel into a variable and passes 0 items / undefined total when section.isLoading is true. This prevents stale "View X more" counts from appearing while skeleton loaders are shown during a new search query.

  2. viewMoreLabel.test.ts: Adds unit tests covering the loading state behavior (0 items, no serverTotal → returns 'trending.view_all').

The only E2E tag relevant here is SmokeWalletPlatform, which covers the Trending discovery tab including search functionality and browsing content feeds. The change is a low-risk UI fix with no impact on controllers, navigation, shared components, or other feature areas. No dependent tags are required per the tag descriptions.

Performance Test Selection:
The changes are a minor UI fix for loading state display in search result section headers. No performance-sensitive code paths are affected — no list rendering changes, no state management changes, no data loading changes, and no component structure changes that would impact render performance.

View GitHub Actions results

@juanmigdr juanmigdr enabled auto-merge May 26, 2026 08:18
@sonarqubecloud

Copy link
Copy Markdown

@juanmigdr juanmigdr added this pull request to the merge queue May 26, 2026
Merged via the queue into main with commit 92f7832 May 26, 2026
194 checks passed
@juanmigdr juanmigdr deleted the fix/explore-search-shows-count branch May 26, 2026 09:13
@github-actions github-actions Bot locked and limited conversation to collaborators May 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants