Skip to content

ci: re-run CI on finished runs when e2e labels are modified in the PR…#30602

Merged
jvbriones merged 2 commits into
mainfrom
ci-rerun-e2e
May 25, 2026
Merged

ci: re-run CI on finished runs when e2e labels are modified in the PR…#30602
jvbriones merged 2 commits into
mainfrom
ci-rerun-e2e

Conversation

@jvbriones

@jvbriones jvbriones commented May 25, 2026

Copy link
Copy Markdown
Contributor

Description

Fix re-run CI on finished runs when e2e labels are modified in the PR

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Only changes a GitHub Actions helper workflow; no app runtime, auth, or data paths.

Overview
Tightens the Rerun CI on skipped E2E labels workflow so label changes can re-trigger CI even when the latest run has already finished, not only while runs are still active.

The job now runs only on open PRs (that guard moved from the rerun step into the job if). Finding the run to rerun filters ci.yml runs with --event pull_request. After cancel, the wait step polls that run’s status via gh run view instead of counting every in-progress/queued run on the branch. The rerun step treats a failed gh run rerun as a soft outcome when the run isn’t retriable, instead of failing the workflow outright.

Reviewed by Cursor Bugbot for commit c620e90. Bugbot is set up for automated code reviews on this repo. Configure here.

@jvbriones jvbriones requested a review from a team as a code owner May 25, 2026 17:45
@jvbriones jvbriones added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label May 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-qa QA team label May 25, 2026
@jvbriones jvbriones enabled auto-merge May 25, 2026 17:46

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 448ab1d. Configure here.

Comment thread .github/workflows/rerun-ci-on-skipped-e2e-labels.yml
@sonarqubecloud

Copy link
Copy Markdown

@jvbriones jvbriones added this pull request to the merge queue May 25, 2026
Merged via the queue into main with commit 761019c May 25, 2026
106 checks passed
@jvbriones jvbriones deleted the ci-rerun-e2e branch May 25, 2026 18:24
@github-actions github-actions Bot locked and limited conversation to collaborators May 25, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.80.0 Issue or pull request that will be included in release 7.80.0 label May 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.80.0 Issue or pull request that will be included in release 7.80.0 size-S team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants