Skip to content

feat: update Telegram Flask client IDs#30578

Merged
tylerc-consensys merged 2 commits into
mainfrom
feat/telegram-flask-client-ids
May 26, 2026
Merged

feat: update Telegram Flask client IDs#30578
tylerc-consensys merged 2 commits into
mainfrom
feat/telegram-flask-client-ids

Conversation

@tylerc-consensys

@tylerc-consensys tylerc-consensys commented May 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Updates Telegram OAuth client IDs for Flask builds in development, UAT, and production so each environment points to the deployed Telegram app configuration.

Adds a config test that pins the deployed Flask Telegram client IDs and catches accidental drift.

Changelog

CHANGELOG entry: Fixed Telegram login configuration for Flask builds

Related issues

Refs: No linked issue. Configuration update for deployed Flask Telegram client IDs.

Manual testing steps

Feature: Telegram login client ID configuration

  Scenario: Flask Telegram client IDs are pinned
    Given the OAuth login handler config tests are run
    When the Telegram Flask client ID assertions execute
    Then the dev, UAT, and production Flask client IDs match the deployed Telegram app IDs

Test command:

yarn jest app/core/OAuthService/OAuthLoginHandlers/config.test.ts

Screenshots/Recordings

N/A - configuration-only change with no UI surface.

Pre-merge author checklist

Performance checks (if applicable)

N/A - configuration-only OAuth client ID update.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tylerc-consensys tylerc-consensys requested a review from a team as a code owner May 25, 2026 07:17
@github-actions

github-actions Bot commented May 25, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tylerc-consensys tylerc-consensys added the team-onboarding Onboarding team label May 25, 2026
@tylerc-consensys tylerc-consensys force-pushed the feat/telegram-flask-client-ids branch from 1c6637d to 5af0706 Compare May 25, 2026 09:14
grvgoel81
grvgoel81 approved these changes May 25, 2026
View reviewed changes

@grvgoel81 grvgoel81 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions

github-actions Bot commented May 25, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeSeedlessOnboarding
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are purely configuration updates - rotating/updating Telegram OAuth client IDs for three Flask build variants (flask_prod, flask_uat, flask_dev). No logic, structure, or API changes are made. The config.test.ts adds a test to verify the new client ID values.

The TELEGRAM_CLIENT_ID values are consumed by constants.ts in the OAuthLoginHandlers, which feeds into the seedless onboarding flow (social login via OAuth providers). Since this affects OAuth configuration, SmokeSeedlessOnboarding is the most relevant tag as it tests the SeedlessOnboardingController mock integration and OAuth token exchange flows.

The changes only affect Flask build variants, not the main/production build, which limits the blast radius. No other E2E test areas are impacted - no UI components, no navigation, no transaction flows, no network changes, no account management logic changes.

Performance Test Selection:
This is a pure configuration change updating Telegram OAuth client IDs. There is no UI rendering, state management, data loading, or critical user flow logic changed. No performance impact is expected from updating credential/ID string values in a config file.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented May 25, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tylerc-consensys tylerc-consensys added this pull request to the merge queue May 26, 2026
Merged via the queue into main with commit 9227392 May 26, 2026
188 of 194 checks passed
@tylerc-consensys tylerc-consensys deleted the feat/telegram-flask-client-ids branch May 26, 2026 01:12
@github-actions github-actions Bot locked and limited conversation to collaborators May 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@himanshuchawla009 himanshuchawla009 himanshuchawla009 approved these changes

@grvgoel81 grvgoel81 grvgoel81 approved these changes

Assignees

No one assigned

Labels

size-S team-onboarding Onboarding team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tylerc-consensys @himanshuchawla009 @grvgoel81