Skip to content

fix: update react native ble plx to 3.5.1#30540

Open
owencraston wants to merge 2 commits into
mainfrom
fix/update-rn-ble
Open

fix: update react native ble plx to 3.5.1#30540
owencraston wants to merge 2 commits into
mainfrom
fix/update-rn-ble

Conversation

@owencraston

@owencraston owencraston commented May 21, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Changelog

CHANGELOG entry:

Related issues

Fixes: #30491

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Upgrades a Bluetooth LE dependency used for device connectivity; behavior changes in the native BLE stack could affect pairing/scanning reliability on iOS/Android despite the small diff.

Overview
Updates the app’s BLE dependency by bumping react-native-ble-plx from 3.4.0 to 3.5.1 in package.json.

Refreshes yarn.lock to resolve to 3.5.1 (new lock entry/checksum) so installs/builds use the updated native Bluetooth library.

Reviewed by Cursor Bugbot for commit b25abf3. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-accounts-framework Accounts team label May 21, 2026
@socket-security

socket-security Bot commented May 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Addednpm/​react-native-ble-plx@​3.5.19910010085100

View full report

@github-actions

github-actions Bot commented May 22, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

E2E Test Selection:
The PR makes a single focused change: bumping react-native-ble-plx from 3.4.0 to 3.5.1. This BLE library is used exclusively in app/core/HardwareWallet/adapters/LedgerBluetoothAdapter.ts for Bluetooth Low Energy communication with Ledger hardware wallets. The import is specifically import { State as BleState } from 'react-native-ble-plx' used for BLE state monitoring (PoweredOn state detection). This is a minor version bump (patch + minor), likely containing bug fixes. The only E2E tag that covers hardware wallet functionality is SmokeAccounts, which tests adding QR-based hardware wallet accounts and account management flows. No other app functionality is affected by this change, so no other tags are needed. Performance tests are not warranted as this is a BLE library update with no impact on rendering, data loading, or standard app flows.

Performance Test Selection:
The change is a minor version bump of react-native-ble-plx, a BLE library used only for Ledger hardware wallet Bluetooth connectivity. This has no impact on app rendering performance, data loading, account list rendering, login flows, or any other performance-sensitive areas measured by the available performance test tags.

View GitHub Actions results

@nikolastoimenovski-consensys

nikolastoimenovski-consensys commented May 22, 2026

Copy link
Copy Markdown

I have used github actions to create an Android build https://github.com/MetaMask/metamask-mobile/actions/runs/26284325977/job/77368017844 to test this PR. The issue is reproducible, the app crashes after trying to add ledger account or using pagination. Video attached

Screen_Recording_20260522_140047_Settings.mp4

@owencraston

owencraston commented May 22, 2026

Copy link
Copy Markdown
Contributor Author

Confirming this did not fix the issue when I tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size-XS team-accounts-framework Accounts team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: [Ledger] Select Account - The app crashes when the user tries to add Ledger account or use the pagination

3 participants

@owencraston @nikolastoimenovski-consensys @dawnseeker8