Skip to content

fix(predict): hidden outcome buttons on single outcome market details cp-7.79.0 #30536

Merged
matallui merged 5 commits into
mainfrom
predict/fix-hidden-buttons
May 21, 2026
Merged

fix(predict): hidden outcome buttons on single outcome market details cp-7.79.0 #30536
matallui merged 5 commits into
mainfrom
predict/fix-hidden-buttons

Conversation

@caieu

@caieu caieu commented May 21, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes collapsed Predict market detail action buttons for single-outcome markets. The Yes/No footer actions were rendering as visible controls, but their parent action columns could measure too small, which made the footer border appear in the wrong place and left the buttons visually clipped.

This change reserves the expected action button height in the Predict market details action columns while preserving the existing showPayoutEstimate layout behavior. It also adjusts the fee exemption label positioning so it remains anchored with the footer layout.

Changelog

CHANGELOG entry: Fixed a bug that caused Predict market action buttons to appear collapsed on single-outcome market details.

Related issues

Fixes: PRED-926 https://consensyssoftware.atlassian.net/browse/PRED-926?atlOrigin=eyJpIjoiOWEwZDE0N2ZhZTZlNGYwNzk5NGI3OTFkZGQyNDFkNjgiLCJwIjoiaiJ9

Manual testing steps

Feature: Predict market details footer actions

  Scenario: single-outcome market details show Yes and No actions
    Given the user opens an open Predict market details screen for a single-outcome market
    And the market has Yes and No outcome tokens

    When the market details screen finishes loading
    Then the Yes and No footer action buttons are fully visible
    And the footer border is positioned above the full action area
    And existing position content remains visible above the footer

Screenshots/Recordings

Before

Screenshot 2026-05-21 at 13 50 44

Yes/No footer action buttons appeared collapsed, with only a thin strip visible and the footer border positioned through the action area.

After

Screenshot 2026-05-21 at 13 49 29

Yes/No footer action buttons are fully visible at the bottom of the market details screen.

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the tic

Note

Low Risk
Low risk UI/layout change that adds minimum height constraints to footer action columns/buttons and adjusts a label’s positioning; behavior changes are limited to Predict market details rendering.

Overview
Fixes a Predict market details layout bug where the Yes/No footer actions could collapse/clipped in single-outcome markets by reserving a minimum height for both the action buttons and their containing columns.

Also tweaks the fee exemption banner styling by moving absolute positioning into twClassName so it stays anchored correctly with the footer, and adds a test asserting the action columns maintain the expected minimum height.

Reviewed by Cursor Bugbot for commit 10a2c17. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label May 21, 2026
@metamaskbotv2 metamaskbotv2 Bot added the team-predict Predict team label May 21, 2026
@caieu caieu marked this pull request as ready for review May 21, 2026 16:58
@caieu caieu requested a review from a team as a code owner May 21, 2026 16:58
@caieu caieu removed the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label May 21, 2026
@matallui matallui enabled auto-merge May 21, 2026 17:21

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8e24e64. Configure here.

@ghgoodreau ghgoodreau changed the title fix(predict): hidden outcome buttons on single outcome market details fix(predict): hidden outcome buttons on single outcome market details cp-7.79.0 May 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokePredictions, SmokeWalletPlatform, SmokeConfirmations
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are isolated UI/styling fixes within the Predict (Polymarket) feature:

  1. PredictMarketDetails.tsx: Minor styling refactor - moves style={tw\absolute inset-x-0 bottom-4 pb-3`}from astyleprop intotwClassName` for the fee exemption box. Functionally equivalent, just consolidating styling approach.

  2. PredictMarketDetailsActions.tsx: Layout fix - adds minHeight: TALL_ACTION_BUTTON_MIN_HEIGHT to action button and column styles to ensure consistent button heights in the YES/NO action columns.

  3. PredictMarketDetailsActions.test.tsx: Adds unit test coverage for the new minHeight styling behavior, plus helper utilities (flattenStyle, findJsonNodes).

No shared components, controllers, navigation, or core infrastructure is affected. Changes are entirely within the Predict feature's market details view.

SmokePredictions: Directly required - changes are in PredictMarketDetails and PredictMarketDetailsActions components which are core to the prediction market flow.

SmokeWalletPlatform: Required per SmokePredictions tag description - "Predictions is also a section inside the Trending tab (SmokeWalletPlatform); changes to Predictions views affect Trending. When selecting SmokePredictions, also select SmokeWalletPlatform."

SmokeConfirmations: Required per SmokePredictions tag description - "opening/closing positions are on-chain transactions. When selecting SmokePredictions, also select SmokeConfirmations."

Performance Test Selection:
The changes are minor UI styling fixes (minHeight values, CSS class consolidation) within the Predict feature. These are too small and isolated to meaningfully impact app performance metrics. No data loading, state management, list rendering, or critical flow changes are involved.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@matallui matallui added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label May 21, 2026
@matallui matallui added this pull request to the merge queue May 21, 2026
Merged via the queue into main with commit 8cb8957 May 21, 2026
285 of 294 checks passed
@matallui matallui deleted the predict/fix-hidden-buttons branch May 21, 2026 22:52
@github-actions github-actions Bot locked and limited conversation to collaborators May 21, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.80.0 Issue or pull request that will be included in release 7.80.0 label May 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.80.0 Issue or pull request that will be included in release 7.80.0 size-S skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-predict Predict team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants