Skip to content

chore(runway): cherry-pick fix: show fallback token icons in confirmation rows cp-7.78.0#30533

Merged
chloeYue merged 1 commit into
release/7.78.0from
runway-cherry-pick-7.78.0-1779377063
May 21, 2026
Merged

chore(runway): cherry-pick fix: show fallback token icons in confirmation rows cp-7.78.0#30533
chloeYue merged 1 commit into
release/7.78.0from
runway-cherry-pick-7.78.0-1779377063

Conversation

@runway-github

@runway-github runway-github Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes missing token icons in confirmation rows when token metadata is
unavailable in local token state. The confirmation TokenIcon now falls
back to the shared MetaMask token icon URL when it has an address, chain
ID, and symbol, while still rendering nothing when neither token
metadata nor a symbol is available.

This also passes the receive token symbol from PayWithRow into
TokenIcon, so Perps and Predict deposit/withdraw rows can render the
token icon fallback for mUSD and other supported ERC-20 tokens with
missing local metadata.

Changelog

CHANGELOG entry: Show fallback token icons in confirmation rows

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/CONF-1411

Manual testing steps

Feature: Confirmation token icon fallback

  Scenario: user withdraws mUSD from Perps or Predict
    Given the user has an mUSD balance
    And the user starts a Perps or Predict withdraw flow

    When the Receive row displays mUSD
    Then the mUSD token icon is shown next to the token symbol

Screenshots/Recordings

Before

After

N/A

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
  • Use these power-user
    SRPs

    to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production
    performance metrics
  • See trace() for usage and
    addToken
    for an example

For performance guidelines and tooling, see the Performance
Guide
.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Low Risk
Low risk UI change that only affects how token icons are
resolved/rendered in confirmation rows. Main risk is incorrect fallback
URL generation for some chains, but it’s covered by new unit tests.

Overview
Fixes missing token icons in confirmation flows by updating
TokenIcon to accept an optional symbol and, when local token
metadata is absent, fall back to a MetaMask-hosted token icon URL (while
still rendering nothing when neither metadata nor symbol is
available).

Updates PayWithRow to pass the displayed token symbol into
TokenIcon (notably for Receive/withdraw rows), and expands unit
tests to validate symbol propagation and fallback URL generation across
multiple supported chains.

Reviewed by Cursor Bugbot for commit
8921cc4. Bugbot is set up for automated
code reviews on this repo. Configure
here.

[a0f1af8](https://github.com/MetaMask/metamask-mobile/commit/a0f1af8f9ed91a43643e4d0f6f22af0bdcc93ebc)

…tion rows cp-7.78.0 (#30502)

## **Description**

Fixes missing token icons in confirmation rows when token metadata is
unavailable in local token state. The confirmation `TokenIcon` now falls
back to the shared MetaMask token icon URL when it has an address, chain
ID, and symbol, while still rendering nothing when neither token
metadata nor a symbol is available.

This also passes the receive token symbol from `PayWithRow` into
`TokenIcon`, so Perps and Predict deposit/withdraw rows can render the
token icon fallback for mUSD and other supported ERC-20 tokens with
missing local metadata.

## **Changelog**

CHANGELOG entry: Show fallback token icons in confirmation rows

## **Related issues**

Fixes: https://consensyssoftware.atlassian.net/browse/CONF-1411

## **Manual testing steps**

```gherkin
Feature: Confirmation token icon fallback

  Scenario: user withdraws mUSD from Perps or Predict
    Given the user has an mUSD balance
    And the user starts a Perps or Predict withdraw flow

    When the Receive row displays mUSD
    Then the mUSD token icon is shown next to the token symbol
```

## **Screenshots/Recordings**

### **Before**


### **After**

N/A

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

#### Performance checks (if applicable)

- [ ] I've tested on Android
  - Ideally on a mid-range device; emulator is acceptable
- [ ] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example

For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Low risk UI change that only affects how token icons are
resolved/rendered in confirmation rows. Main risk is incorrect fallback
URL generation for some chains, but it’s covered by new unit tests.
> 
> **Overview**
> Fixes missing token icons in confirmation flows by updating
`TokenIcon` to accept an optional `symbol` and, when local token
metadata is absent, fall back to a MetaMask-hosted token icon URL (while
still rendering nothing when neither metadata nor `symbol` is
available).
> 
> Updates `PayWithRow` to pass the displayed token `symbol` into
`TokenIcon` (notably for *Receive/withdraw* rows), and expands unit
tests to validate symbol propagation and fallback URL generation across
multiple supported chains.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
8921cc4. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@runway-github runway-github Bot requested a review from a team as a code owner May 21, 2026 15:24
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label May 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - PR targets a release branch (release/*)

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@chloeYue chloeYue left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chloeYue chloeYue merged commit 8f39d77 into release/7.78.0 May 21, 2026
294 of 299 checks passed
@chloeYue chloeYue deleted the runway-cherry-pick-7.78.0-1779377063 branch May 21, 2026 18:02
@github-actions github-actions Bot locked and limited conversation to collaborators May 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size-M team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants