chore(runway): cherry-pick fix: show fallback token icons in confirmation rows cp-7.78.0#30533
Merged
Merged
Conversation
…tion rows cp-7.78.0 (#30502) ## **Description** Fixes missing token icons in confirmation rows when token metadata is unavailable in local token state. The confirmation `TokenIcon` now falls back to the shared MetaMask token icon URL when it has an address, chain ID, and symbol, while still rendering nothing when neither token metadata nor a symbol is available. This also passes the receive token symbol from `PayWithRow` into `TokenIcon`, so Perps and Predict deposit/withdraw rows can render the token icon fallback for mUSD and other supported ERC-20 tokens with missing local metadata. ## **Changelog** CHANGELOG entry: Show fallback token icons in confirmation rows ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/CONF-1411 ## **Manual testing steps** ```gherkin Feature: Confirmation token icon fallback Scenario: user withdraws mUSD from Perps or Predict Given the user has an mUSD balance And the user starts a Perps or Predict withdraw flow When the Receive row displays mUSD Then the mUSD token icon is shown next to the token symbol ``` ## **Screenshots/Recordings** ### **Before** ### **After** N/A ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [ ] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [ ] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [ ] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk UI change that only affects how token icons are resolved/rendered in confirmation rows. Main risk is incorrect fallback URL generation for some chains, but it’s covered by new unit tests. > > **Overview** > Fixes missing token icons in confirmation flows by updating `TokenIcon` to accept an optional `symbol` and, when local token metadata is absent, fall back to a MetaMask-hosted token icon URL (while still rendering nothing when neither metadata nor `symbol` is available). > > Updates `PayWithRow` to pass the displayed token `symbol` into `TokenIcon` (notably for *Receive/withdraw* rows), and expands unit tests to validate symbol propagation and fallback URL generation across multiple supported chains. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 8921cc4. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - PR targets a release branch (release/*) All E2E tests pre-selected. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Fixes missing token icons in confirmation rows when token metadata is
unavailable in local token state. The confirmation
TokenIconnow fallsback to the shared MetaMask token icon URL when it has an address, chain
ID, and symbol, while still rendering nothing when neither token
metadata nor a symbol is available.
This also passes the receive token symbol from
PayWithRowintoTokenIcon, so Perps and Predict deposit/withdraw rows can render thetoken icon fallback for mUSD and other supported ERC-20 tokens with
missing local metadata.
Changelog
CHANGELOG entry: Show fallback token icons in confirmation rows
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/CONF-1411
Manual testing steps
Screenshots/Recordings
Before
After
N/A
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Performance checks (if applicable)
SRPs
to import wallets with many accounts and tokens
performance metrics
trace()for usage andaddTokenfor an example
For performance guidelines and tooling, see the Performance
Guide.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Low Risk
Low risk UI change that only affects how token icons are
resolved/rendered in confirmation rows. Main risk is incorrect fallback
URL generation for some chains, but it’s covered by new unit tests.
Overview
Fixes missing token icons in confirmation flows by updating
TokenIconto accept an optionalsymboland, when local tokenmetadata is absent, fall back to a MetaMask-hosted token icon URL (while
still rendering nothing when neither metadata nor
symbolisavailable).
Updates
PayWithRowto pass the displayed tokensymbolintoTokenIcon(notably for Receive/withdraw rows), and expands unittests to validate symbol propagation and fallback URL generation across
multiple supported chains.
Reviewed by Cursor Bugbot for commit
8921cc4. Bugbot is set up for automated
code reviews on this repo. Configure
here.