Skip to content

chore: build android in prod#30506

Merged
andrepimenta merged 1 commit into
mainfrom
chore/prod-in-build-android
May 21, 2026
Merged

chore: build android in prod#30506
andrepimenta merged 1 commit into
mainfrom
chore/prod-in-build-android

Conversation

@tommasini

@tommasini tommasini commented May 21, 2026

Copy link
Copy Markdown
Contributor

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk workflow-only change that expands allowed environment inputs to include prod; impact is limited to CI behavior for Android builds.

Overview
Enables building Android in the prod track by adding prod to the environment input contract for .github/workflows/build-android.yml (both workflow_call and manual workflow_dispatch).

Updates the input validation case statement and the dispatch choice options to accept prod, preventing builds from failing input validation when targeting production.

Reviewed by Cursor Bugbot for commit 0070f39. Bugbot is set up for automated code reviews on this repo. Configure here.

@tommasini tommasini requested a review from a team as a code owner May 21, 2026 10:17
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-mobile-platform Mobile Platform team label May 21, 2026
@tommasini tommasini enabled auto-merge May 21, 2026 10:18
@andrepimenta andrepimenta disabled auto-merge May 21, 2026 10:18
@andrepimenta andrepimenta merged commit 83098a2 into main May 21, 2026
64 of 68 checks passed
@andrepimenta andrepimenta deleted the chore/prod-in-build-android branch May 21, 2026 10:18
@github-actions github-actions Bot locked and limited conversation to collaborators May 21, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.79.0 Issue or pull request that will be included in release 7.79.0 label May 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.79.0 Issue or pull request that will be included in release 7.79.0 size-S team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants