Skip to content

fix: attach AB testing params to whats happening events#30498

Merged
joaosantos15 merged 3 commits into
mainfrom
TSA-568-attach-ab-testing-to-whats-happening-events
May 21, 2026
Merged

fix: attach AB testing params to whats happening events#30498
joaosantos15 merged 3 commits into
mainfrom
TSA-568-attach-ab-testing-to-whats-happening-events

Conversation

@joaosantos15

@joaosantos15 joaosantos15 commented May 21, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Adds missing ab testing properties to whats happening events.

Changelog

CHANGELOG entry: no-changelog

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: expands analytics allowlisting for an existing A/B test and adds unit coverage; no changes to business logic beyond which events get enriched.

Overview
Ensures the Whats Happening Explore A/B test assignment (active_ab_tests) is attached to additional Whats Happening analytics events, not just EXPLORE_INTERACTED.

Updates the allowlist in TrendingView/abTestConfig.ts to include scroll, details open/view/close, and interaction events, and extends enrichWithABTests test coverage via a parameterized test to validate enrichment across those event types.

Reviewed by Cursor Bugbot for commit f6e0a02. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-social-ai Social & AI team label May 21, 2026
cursor[bot]
cursor Bot reviewed May 21, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8748618. Configure here.

Comment thread app/util/analytics/enrichWithABTests.test.ts
zone-live
zone-live previously approved these changes May 21, 2026
View reviewed changes
@github-actions

github-actions Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeWalletPlatform
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are confined to two files:

  1. app/components/Views/TrendingView/abTestConfig.ts: Adds 5 additional WHATS_HAPPENING_* analytics event names to the A/B test analytics mapping. This is a pure analytics configuration change — it extends which events get enriched with A/B test assignment data. No UI, no navigation, no controller logic is changed.

  2. app/util/analytics/enrichWithABTests.test.ts: Adds unit tests (not E2E tests) to verify the new event mappings work correctly.

The TrendingView is part of the SmokeWalletPlatform tag (Trending discovery tab). Since the change touches the TrendingView's A/B test config, a minimal smoke run of SmokeWalletPlatform is appropriate to confirm the analytics enrichment doesn't break any Trending-related flows. However, the risk is very low — this is purely additive analytics metadata configuration with no functional behavior change.

No other tags are warranted: no confirmations, no accounts, no networks, no swaps, no snaps, no browser, no identity flows are affected.

Performance Test Selection:
The changes are purely analytics event name configuration additions to an A/B test mapping. There is no UI rendering, data loading, state management, or critical user flow impact. No performance tests are warranted.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented May 21, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@joaosantos15 joaosantos15 added this pull request to the merge queue May 21, 2026
Merged via the queue into main with commit 9a2d990 May 21, 2026
169 of 192 checks passed
@joaosantos15 joaosantos15 deleted the TSA-568-attach-ab-testing-to-whats-happening-events branch May 21, 2026 12:07
@github-actions github-actions Bot locked and limited conversation to collaborators May 21, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.79.0 Issue or pull request that will be included in release 7.79.0 label May 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@zone-live zone-live zone-live approved these changes

Assignees

No one assigned

Labels

release-7.79.0 Issue or pull request that will be included in release 7.79.0 size-S team-social-ai Social & AI team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joaosantos15 @zone-live