Skip to content

test(snaps): Re-enable BIP-44 test#30493

Merged
FrederikBolding merged 1 commit into
mainfrom
fb/re-enable-bip44-test
May 21, 2026
Merged

test(snaps): Re-enable BIP-44 test#30493
FrederikBolding merged 1 commit into
mainfrom
fb/re-enable-bip44-test

Conversation

@FrederikBolding

@FrederikBolding FrederikBolding commented May 21, 2026

Copy link
Copy Markdown
Member

Description

Re-enable the BIP-44 test after disabling device synchronization across all Snaps tests.

Changelog

CHANGELOG entry: null


Note

Low Risk
Low risk: only changes test execution by re-enabling an existing smoke spec, with no production code impact.

Overview
Re-enables the BIP-44 Snap Tests smoke suite by removing describe.skip, so the BIP-44 Snap connection/signing/entropy tests run again in CI.

Reviewed by Cursor Bugbot for commit 20422fb. Bugbot is set up for automated code reviews on this repo. Configure here.

@FrederikBolding FrederikBolding added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label May 21, 2026
@metamaskbotv2 metamaskbotv2 Bot added team-core-platform Core Platform team INVALID-PR-TEMPLATE PR's body doesn't match template labels May 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeSnaps
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 98%
click to see 🤖 AI reasoning details

E2E Test Selection:
The only change in this PR is removing .skip from the describe.skip(SmokeSnaps('BIP-44 Snap Tests'), ...) block in tests/smoke/snaps/test-snap-bip-44.spec.ts. This re-enables previously skipped BIP-44 snap tests. The change is entirely within the SmokeSnaps test directory and only affects test execution (no app code changes). The SmokeSnaps tag directly covers BIP-44 key derivation tests for snap account management. No other tags are impacted since no app code, controllers, or shared components were modified.

Performance Test Selection:
No app code was changed - only a test file had its .skip removed. There is no performance impact from this change.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@FrederikBolding FrederikBolding marked this pull request as ready for review May 21, 2026 08:31
@FrederikBolding FrederikBolding requested a review from a team as a code owner May 21, 2026 08:31
@FrederikBolding FrederikBolding enabled auto-merge May 21, 2026 08:31
@FrederikBolding FrederikBolding requested a review from Mrtenz May 21, 2026 09:34
@FrederikBolding FrederikBolding added this pull request to the merge queue May 21, 2026
Merged via the queue into main with commit 229a155 May 21, 2026
293 of 318 checks passed
@FrederikBolding FrederikBolding deleted the fb/re-enable-bip44-test branch May 21, 2026 10:02
@github-actions github-actions Bot locked and limited conversation to collaborators May 21, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.79.0 Issue or pull request that will be included in release 7.79.0 label May 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.79.0 Issue or pull request that will be included in release 7.79.0 size-XS team-core-platform Core Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants