chore(runway): cherry-pick fix: football prediction markets not loading#30490
Merged
Conversation
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until this PR meets the canonical Definition of Ready For Review in `docs/readme/ready-for-review.md`. In short: the template must be materially complete (not just section titles present), all status checks must be currently passing, and the only expected follow-up commits must be reviewer-driven. --> **Root cause:** The Polymarket API returns `null` for the `orderPriceMinTickSize` field on some sports markets. Our code was calling `.toString()` on that value without a null check, which threw a runtime error. Since the entire batch of events was parsed in a single `.map()`, one bad event crashed the whole thing and returned an empty list. **Fix:** 1. Changed `market.orderPriceMinTickSize.toString()` to `market.orderPriceMinTickSize?.toString() ?? '0.01'` to safely handle the null. 2. Updated the TypeScript type to `number | null` to correctly reflect what the API actually returns. 3. Changed the event parsing loop from `.map()` to `.flatMap()` with a per-event `try/catch`, so a single malformed event is skipped and logged instead of taking down the whole batch. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: football prediction markets not loading Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-3259 ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> https://github.com/user-attachments/assets/3fb77be4-1060-45c3-adb2-cb75cd4f41a8 <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/464094d7-94ea-4002-8531-498bb6d173da <!-- [screenshots/recordings] --> <!-- Every checklist item must be consciously assessed before marking this PR as "Ready for review". A checked box means you deliberately considered that responsibility, not that you literally performed every action listed. Unchecked boxes are ambiguous: they are not an implicit "N/A" and they are not a silent "skip". See `docs/readme/ready-for-review.md` for the full checklist semantics. --> - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [ ] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [ ] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). <!-- Reviewer checklist items follow the same semantics as the author checklist: an unchecked box is ambiguous, a checked box means the reviewer consciously assessed that responsibility. See `docs/readme/ready-for-review.md`. --> - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Changes market parsing defaults and error handling for Polymarket events; while localized, it can affect tick-size-dependent pricing behavior and which events appear if parsing failures occur. > > **Overview** > Fixes Polymarket sports markets failing to load when the API returns a `null` `orderPriceMinTickSize`. > > Updates the Polymarket market type to allow `orderPriceMinTickSize: number | null`, safely derives `tickSize` with a fallback default, and makes `parsePolymarketEvents` resilient by parsing each event in a `try/catch` (logging and skipping only the bad event instead of failing the whole batch). > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 1f8de4a. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Luis Taniça <matallui@gmail.com>
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - PR targets a release branch (release/*) All E2E tests pre-selected. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Root cause: The Polymarket API returns
nullfor theorderPriceMinTickSizefield on some sports markets. Our code wascalling
.toString()on that value without a null check, which threw aruntime error. Since the entire batch of events was parsed in a single
.map(), one bad event crashed the whole thing and returned an emptylist.
Fix:
market.orderPriceMinTickSize.toString()tomarket.orderPriceMinTickSize?.toString() ?? '0.01'to safely handlethe null.
number | nullto correctly reflectwhat the API actually returns.
.map()to.flatMap()with aper-event
try/catch, so a single malformed event is skipped and loggedinstead of taking down the whole batch.
Changelog
CHANGELOG entry: football prediction markets not loading
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-3259
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2026-05-20.at.18.52.11.mov
After
Screen.Recording.2026-05-20.at.18.53.10.mov
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Performance checks (if applicable)
SRPs
to import wallets with many accounts and tokens
performance metrics
trace()for usage andaddTokenfor an example
For performance guidelines and tooling, see the Performance
Guide.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Medium Risk
Changes market parsing defaults and error handling for Polymarket
events; while localized, it can affect tick-size-dependent pricing
behavior and which events appear if parsing failures occur.
Overview
Fixes Polymarket sports markets failing to load when the API returns a
nullorderPriceMinTickSize.Updates the Polymarket market type to allow
orderPriceMinTickSize: number | null, safely derivestickSizewith a fallback default, andmakes
parsePolymarketEventsresilient by parsing each event in atry/catch(logging and skipping only the bad event instead of failingthe whole batch).
Reviewed by Cursor Bugbot for commit
1f8de4a. Bugbot is set up for automated
code reviews on this repo. Configure
here.
Co-authored-by: Luis Taniça matallui@gmail.com e9fa454