Skip to content

chore(runway): cherry-pick fix: football prediction markets not loading#30490

Merged
chloeYue merged 1 commit into
release/7.78.0from
cherry-pick-7-78-0-e9fa454
May 21, 2026
Merged

chore(runway): cherry-pick fix: football prediction markets not loading#30490
chloeYue merged 1 commit into
release/7.78.0from
cherry-pick-7-78-0-e9fa454

Conversation

@runway-github

@runway-github runway-github Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

Description

Root cause: The Polymarket API returns null for the
orderPriceMinTickSize field on some sports markets. Our code was
calling .toString() on that value without a null check, which threw a
runtime error. Since the entire batch of events was parsed in a single
.map(), one bad event crashed the whole thing and returned an empty
list.

Fix:

  1. Changed market.orderPriceMinTickSize.toString() to
    market.orderPriceMinTickSize?.toString() ?? '0.01' to safely handle
    the null.
  2. Updated the TypeScript type to number | null to correctly reflect
    what the API actually returns.
  3. Changed the event parsing loop from .map() to .flatMap() with a
    per-event try/catch, so a single malformed event is skipped and logged
    instead of taking down the whole batch.

Changelog

CHANGELOG entry: football prediction markets not loading

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-3259

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

Screen.Recording.2026-05-20.at.18.52.11.mov

After

Screen.Recording.2026-05-20.at.18.53.10.mov

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
  • Use these power-user
    SRPs

    to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production
    performance metrics
  • See trace() for usage and
    addToken
    for an example

For performance guidelines and tooling, see the Performance
Guide
.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Medium Risk
Changes market parsing defaults and error handling for Polymarket
events; while localized, it can affect tick-size-dependent pricing
behavior and which events appear if parsing failures occur.

Overview
Fixes Polymarket sports markets failing to load when the API returns a
null orderPriceMinTickSize.

Updates the Polymarket market type to allow orderPriceMinTickSize: number | null, safely derives tickSize with a fallback default, and
makes parsePolymarketEvents resilient by parsing each event in a
try/catch (logging and skipping only the bad event instead of failing
the whole batch).

Reviewed by Cursor Bugbot for commit
1f8de4a. Bugbot is set up for automated
code reviews on this repo. Configure
here.


Co-authored-by: Luis Taniça matallui@gmail.com e9fa454

<!--
Please submit this PR as a draft initially.

Do not mark it as "Ready for review" until this PR meets the canonical
Definition of Ready For Review in `docs/readme/ready-for-review.md`.

In short: the template must be materially complete (not just section
titles
present), all status checks must be currently passing, and the only
expected
follow-up commits must be reviewer-driven.
-->

**Root cause:** The Polymarket API returns `null` for the
`orderPriceMinTickSize` field on some sports markets. Our code was
calling `.toString()` on that value without a null check, which threw a
runtime error. Since the entire batch of events was parsed in a single
`.map()`, one bad event crashed the whole thing and returned an empty
list.

**Fix:**
1. Changed `market.orderPriceMinTickSize.toString()` to
`market.orderPriceMinTickSize?.toString() ?? '0.01'` to safely handle
the null.
2. Updated the TypeScript type to `number | null` to correctly reflect
what the API actually returns.
3. Changed the event parsing loop from `.map()` to `.flatMap()` with a
per-event `try/catch`, so a single malformed event is skipped and logged
instead of taking down the whole batch.

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: football prediction markets not loading

Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-3259

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

https://github.com/user-attachments/assets/3fb77be4-1060-45c3-adb2-cb75cd4f41a8

<!-- [screenshots/recordings] -->

https://github.com/user-attachments/assets/464094d7-94ea-4002-8531-498bb6d173da

<!-- [screenshots/recordings] -->

<!--
Every checklist item must be consciously assessed before marking this PR
as
"Ready for review". A checked box means you deliberately considered that
responsibility, not that you literally performed every action listed.

Unchecked boxes are ambiguous: they are not an implicit "N/A" and they
are not
a silent "skip". See `docs/readme/ready-for-review.md` for the full
checklist
semantics.
-->

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've tested on Android
  - Ideally on a mid-range device; emulator is acceptable
- [ ] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example

For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).

<!--
Reviewer checklist items follow the same semantics as the author
checklist: an
unchecked box is ambiguous, a checked box means the reviewer consciously
assessed that responsibility. See `docs/readme/ready-for-review.md`.
-->

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Changes market parsing defaults and error handling for Polymarket
events; while localized, it can affect tick-size-dependent pricing
behavior and which events appear if parsing failures occur.
>
> **Overview**
> Fixes Polymarket sports markets failing to load when the API returns a
`null` `orderPriceMinTickSize`.
>
> Updates the Polymarket market type to allow `orderPriceMinTickSize:
number | null`, safely derives `tickSize` with a fallback default, and
makes `parsePolymarketEvents` resilient by parsing each event in a
`try/catch` (logging and skipping only the bad event instead of failing
the whole batch).
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
1f8de4a. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Luis Taniça <matallui@gmail.com>
@runway-github runway-github Bot requested a review from a team as a code owner May 21, 2026 06:27
@metamaskbotv2 metamaskbotv2 Bot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label May 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - PR targets a release branch (release/*)

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
53.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@chloeYue chloeYue left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chloeYue chloeYue added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label May 21, 2026
@chloeYue chloeYue merged commit cc2c7d5 into release/7.78.0 May 21, 2026
299 of 306 checks passed
@chloeYue chloeYue deleted the cherry-pick-7-78-0-e9fa454 branch May 21, 2026 08:03
@github-actions github-actions Bot locked and limited conversation to collaborators May 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size-S skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants