Skip to content

chore: Add a required source branch input to build.yml#30482

Merged
Cal-L merged 2 commits into
mainfrom
chore/MCWP-594-add-input-ref-to-build-yml
May 20, 2026
Merged

chore: Add a required source branch input to build.yml#30482
Cal-L merged 2 commits into
mainfrom
chore/MCWP-594-add-input-ref-to-build-yml

Conversation

@Cal-L

@Cal-L Cal-L commented May 20, 2026

Copy link
Copy Markdown
Contributor

Description

Some of our workflows such as build.yml relies on the main workflow file being run. This is to allow other branches to build while still locking down the workflow from the main branch. This adds a source branch input to the build.yml workflow to allow building from source branches

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

With source input
image

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Medium risk because it changes how build.yml resolves the git ref for checkout and build metadata, which can break callers if they don’t pass source_branch or if the value differs from the triggering ref.

Overview
Makes source_branch a required input for .github/workflows/build.yml and uses it consistently for all checkouts/metadata (removing fallbacks to github.ref_name).

Adds source_branch to manual workflow_dispatch runs (defaulting to main) and updates expo-dev-build.yml to pass the current ref name into the reusable build workflow.

Reviewed by Cursor Bugbot for commit 8bd6417. Bugbot is set up for automated code reviews on this repo. Configure here.

@Cal-L Cal-L requested a review from a team as a code owner May 20, 2026 21:53
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-mobile-platform Mobile Platform team label May 20, 2026
@Cal-L Cal-L added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels May 20, 2026
@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue May 20, 2026
@Cal-L Cal-L added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed no changelog required No changelog entry is required for this change labels May 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
The two changed files are GitHub Actions workflow files for CI/CD build pipelines:

  1. .github/workflows/build.yml: Changed source_branch from an optional parameter (with || github.ref_name fallback) to a required parameter. For workflow_dispatch, added an explicit source_branch input with default: 'main'. All ${{ inputs.source_branch || github.ref_name }} expressions simplified to ${{ inputs.source_branch }}.

  2. .github/workflows/expo-dev-build.yml: Added source_branch: ${{ github.ref_name }} to the build.yml workflow call — this is the companion fix ensuring the caller passes the now-required parameter.

These are purely CI/CD infrastructure changes with no impact on:

  • Application source code
  • E2E test logic or test infrastructure
  • Controllers, Engine, or any core modules
  • UI components or user flows
  • Test fixtures, page objects, or test framework

No E2E tests are needed to validate these workflow-only changes. The changes are self-contained within the build pipeline configuration and do not affect any testable application behavior.

Performance Test Selection:
No application code, rendering logic, state management, or performance-sensitive paths were modified. These are purely CI/CD workflow configuration changes with no impact on app performance.

View GitHub Actions results

@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue May 20, 2026
@Cal-L Cal-L merged commit 15f3c73 into main May 20, 2026
91 checks passed
@Cal-L Cal-L deleted the chore/MCWP-594-add-input-ref-to-build-yml branch May 20, 2026 22:06
@github-actions github-actions Bot locked and limited conversation to collaborators May 20, 2026
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 20, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.79.0 Issue or pull request that will be included in release 7.79.0 label May 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no changelog required No changelog entry is required for this change No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.79.0 Issue or pull request that will be included in release 7.79.0 size-S team-mobile-platform Mobile Platform team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants