Skip to content

chore(rewards): VIP view rework#30479

Merged
VGR-GIT merged 6 commits into
mainfrom
VIP-dashboard-rework
May 21, 2026
Merged

chore(rewards): VIP view rework#30479
VGR-GIT merged 6 commits into
mainfrom
VIP-dashboard-rework

Conversation

@sophieqgu

@sophieqgu sophieqgu commented May 20, 2026 •
edited by Montoya
Loading

Copy link
Copy Markdown
Contributor

Description

VIP dashboard rework
In conjunction: https://github.com/consensys-vertical-apps/va-mmcx-rewards/pull/573

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Moderate risk: updates VIP UI flows and expands VIP dashboard DTOs (points-based progress, new fields like equity rebate/referral carryover), which could break rendering if backend/Redux data mismatches.

Overview
Reworks the Rewards VIP experience to align with the updated VIP dashboard contract: progress and tier thresholds move from swaps/perps requirements to points-based metrics, and VIP volume now includes points, referral points, and referral counts.

Updates the VIP UI to use new backend-provided localized strings, adds a member ID display, introduces an optional Equity rebate fee tile, and revamps styling with a new vip.svg icon and shared gold theme constants. Also enhances the referral details screen to show a VIP-specific info section with loading/error states driven by useVipDashboard, and adds formatCompactValue for non-currency compact number formatting.

Reviewed by Cursor Bugbot for commit b8206f3. Bugbot is set up for automated code reviews on this repo. Configure here.

@sophieqgu sophieqgu requested a review from a team as a code owner May 20, 2026 21:12
@github-actions

github-actions Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-rewards Rewards team label May 20, 2026
cursor[bot]
cursor Bot reviewed May 20, 2026
View reviewed changes
Comment thread app/components/UI/Rewards/components/Vip/VipTierRow.tsx Outdated
Comment thread app/components/UI/Rewards/components/Vip/VipTierProgressCard.test.tsx Outdated
@sophieqgu sophieqgu changed the title VIP view rework chore(rewards): VIP view rework May 20, 2026
@github-actions github-actions Bot added size-XL and removed size-L labels May 20, 2026
cursor[bot]
cursor Bot reviewed May 20, 2026
View reviewed changes
Comment thread app/components/UI/Rewards/components/Vip/VipVolumeSection.tsx
VGR-GIT and others added 2 commits May 21, 2026 10:25
@VGR-GIT @claude
feat(rewards): add equity rebate UI tile + progress-to-equity radial …
3516bdd 
…states

- Adds VipTierDto.equityRebateBps + referralCarryoverBps types
- 4th VipFeeTile in tier-benefits carousel (renders T6+)
- VipPointsSection extends to four states (pre-qual / qualified at T6/T7/T8)
- en.json + locale shells get rewards.vip.equity_rebate_label

## **Changelog**

CHANGELOG entry: Added equity rebate tile and progress-to-equity radial states to the VIP dashboard.

Refs: RWDS-VIP plan §5 step 4
TODO (N1, N2): "Total Points" → "Total points" and "VIP Referrals" → "VIP referrals" pending design sign-off.

Co-authored-by: VGR-GIT <vangulckrik@gmail.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
@VGR-GIT @claude
feat(rewards): add VIP referral details top section with carryover rate
b8206f3 
Conditionally renders a VIP-specific intro on the referral details page
(rev-share copy + Referrals X/cap + current-tier referralCarryoverBps as %)
when the active subscription is VIP. Reads from useVipDashboard with
skeleton + error-banner-with-retry states; non-VIP path is unchanged.

Co-authored-by: VGR-GIT <vangulckrik@gmail.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
cursor[bot]
cursor Bot reviewed May 21, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b8206f3. Configure here.

Comment thread app/components/UI/Rewards/components/Vip/VipTierRow.tsx Outdated
Comment thread locales/languages/en.json
@github-actions

github-actions Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokePerps, SmokeWalletPlatform
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 72%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes in this PR are focused on the Rewards VIP dashboard feature:

  1. RewardsController types.ts (critical file): Updated VIP DTO shapes - VipProgressDto field renames (remainingSwapsUsd/remainingPerpsUsd/estimatedDaysToNextTier → remainingPointsToNextTier), VipVolumeDto additions (points/pointsFromReferrals/referrals/referralsCap), VipTierDto changes (swapsRequirementUsd/perpsRequirementUsd → pointsRequirement, new equityRebateBps and referralCarryoverBps), VipLocalizedTextDto field renames (volumeTitle → statsTitle, new memberIdTitle/nextTierRevenueShareDelta). These are breaking DTO changes but only affect the VIP rewards feature.

  2. UI Components: VIP dashboard redesign with gold color constants, new VipIcon, equity rebate tile, member ID display, updated VipPointsSection with equity qualification logic, VipTierProgressCard gradient redesign.

  3. ReferralInfoSection: Enhanced to show VIP-specific referral info (referrals count, revenue share carryover).

  4. formatUtils: New formatCompactValue utility (refactored from formatCompactUsd).

  5. Localization: New strings across all 20 language files for VIP equity rebate, referrals, points labels.

No E2E tests directly cover the Rewards VIP dashboard. The Rewards feature is accessed via the wallet platform. SmokePerps is selected because the VIP dashboard is closely tied to perps trading (fee discounts, equity rebate for perps traders), and the Perps section is embedded in the Trending tab (SmokeWalletPlatform). SmokeWalletPlatform is selected because the Rewards/VIP feature is part of the wallet platform and the Trending tab integration. No other tags are warranted as the changes don't touch confirmations, swaps, accounts, identity, browser, snaps, or network infrastructure.

Performance Test Selection:
The changes are focused on the Rewards VIP dashboard UI components and DTO type updates. While there are UI rendering changes (new components, redesigned cards), these are within a feature-specific screen (VIP dashboard) that is not part of the critical performance paths measured by the available performance test tags. The changes don't affect app launch, login, account list rendering, swap flows, or asset loading performance. No performance tests are warranted.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented May 21, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
96.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@VGR-GIT VGR-GIT enabled auto-merge May 21, 2026 14:12
@VGR-GIT VGR-GIT added this pull request to the merge queue May 21, 2026
Merged via the queue into main with commit b232e73 May 21, 2026
206 of 212 checks passed
@VGR-GIT VGR-GIT deleted the VIP-dashboard-rework branch May 21, 2026 14:37
@github-actions github-actions Bot locked and limited conversation to collaborators May 21, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.79.0 Issue or pull request that will be included in release 7.79.0 label May 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

+1 more reviewer

@jonson jonson jonson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-7.79.0 Issue or pull request that will be included in release 7.79.0 size-XL team-rewards Rewards team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sophieqgu @jonson @VGR-GIT