Skip to content

chore: rename follow trade notification clicked event#30449

Merged
zone-live merged 2 commits into
mainfrom
TSA-top-traders-event-name-update
May 21, 2026
Merged

chore: rename follow trade notification clicked event#30449
zone-live merged 2 commits into
mainfrom
TSA-top-traders-event-name-update

Conversation

@zone-live

@zone-live zone-live commented May 20, 2026

Copy link
Copy Markdown
Contributor

Description

Renames the Top Traders / social leaderboard analytics event from Follow Trade Notification Clicked to Follow Trading Notification Clicked so it matches the segment-schema definition and naming used by other follow-trading events.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk rename of a single analytics event constant and its usage; main risk is breaking downstream analytics dashboards if consumers still expect the old event name.

Overview
Renames the social leaderboard analytics event from SOCIAL_FOLLOW_TRADE_NOTIFICATION_CLICKED to SOCIAL_FOLLOW_TRADING_NOTIFICATION_CLICKED (and updates the emitted string to "Follow Trading Notification Clicked") in MetaMetrics.events.

Updates handleSocialTraderPositionUrl to track the renamed event when handling notification-driven deeplinks.

Reviewed by Cursor Bugbot for commit d2b7147. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label May 20, 2026
@metamaskbotv2 metamaskbotv2 Bot added the team-social-ai Social & AI team label May 20, 2026
@zone-live zone-live removed the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label May 20, 2026
@zone-live zone-live enabled auto-merge May 21, 2026 13:07
@zone-live zone-live added pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. and removed pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. labels May 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokePredictions
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are a simple analytics event rename: SOCIAL_FOLLOW_TRADE_NOTIFICATION_CLICKED → SOCIAL_FOLLOW_TRADING_NOTIFICATION_CLICKED. This affects:

  1. MetaMetrics.events.ts: Enum value and event string renamed consistently
  2. handleSocialTraderPositionUrl.ts: Updated to use the new event name

The old name has zero remaining references (confirmed by grep), so the rename is complete. No functional logic, UI, state management, or core flow changes were made. The deep link handler is in the Social Trader / Predictions domain, so SmokePredictions is the most relevant tag to validate the deep link flow still works correctly. No other tags are warranted since this is purely an analytics rename with no impact on confirmations, accounts, networks, or other features.

Performance Test Selection:
Analytics event renaming has zero performance impact. No UI rendering, state management, data loading, or app initialization changes were made.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@zone-live zone-live added this pull request to the merge queue May 21, 2026
Merged via the queue into main with commit 0ab7272 May 21, 2026
178 of 204 checks passed
@zone-live zone-live deleted the TSA-top-traders-event-name-update branch May 21, 2026 14:58
@github-actions github-actions Bot locked and limited conversation to collaborators May 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants