Skip to content

ci: filter push and scheduled runs for QA metrics#30438

Merged
jvbriones merged 1 commit into
mainfrom
fix-qa-metrics
May 20, 2026
Merged

ci: filter push and scheduled runs for QA metrics#30438
jvbriones merged 1 commit into
mainfrom
fix-qa-metrics

Conversation

@jvbriones

@jvbriones jvbriones commented May 20, 2026

Copy link
Copy Markdown
Contributor

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Changes how the QA stats script selects the source CI run; if the GitHub Actions API filtering differs from expectations, metrics collection could fail or target an unintended run.

Overview
QA metrics collection now only targets artifacts from main CI runs triggered by push or schedule, avoiding workflow_dispatch/workflow_call runs that don’t publish artifacts to the standard GitHub artifacts API.

collect-qa-stats.mjs fetches the latest successful run for both events in parallel, selects the newest by created_at, and improves logging/error messages to include the chosen run’s event.

Reviewed by Cursor Bugbot for commit 276ea5c. Bugbot is set up for automated code reviews on this repo. Configure here.

@jvbriones jvbriones requested a review from a team as a code owner May 20, 2026 12:15
@jvbriones jvbriones added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label May 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-qa QA team label May 20, 2026
@jvbriones jvbriones enabled auto-merge May 20, 2026 12:15
@sonarqubecloud

Copy link
Copy Markdown

@jvbriones jvbriones added this pull request to the merge queue May 20, 2026
Merged via the queue into main with commit 18f3f9a May 20, 2026
125 of 127 checks passed
@jvbriones jvbriones deleted the fix-qa-metrics branch May 20, 2026 13:17
@github-actions github-actions Bot locked and limited conversation to collaborators May 20, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.79.0 Issue or pull request that will be included in release 7.79.0 label May 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.79.0 Issue or pull request that will be included in release 7.79.0 size-S team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants