feat(money): MUSD-827 Money Home design-review polishes#30437
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
| vaultApyQuery, | ||
| isAggregatedBalanceLoading, | ||
| apyPercent, | ||
| musdFiatFormatted, |
There was a problem hiding this comment.
This musdFiatFormatted represents the mUSD held in the Money Account. The related designs in the ticket mention depositing mUSD into the Money account to earn yield. I suspect that we want to display the selected EVM account's mUSD balance here instead. You can access the active EVM account's mUSD balance via the useMusdBalance hook.
Sidenote - The CHOMP API will be automatically taking mUSD held in the Money account and depositing it into the Veda Vault on behalf of the user. This means the Money account's mUSD balance will likely be zero most of the time.
| const { styles } = useStyles(styleSheet, {}); | ||
|
|
||
| const { totalFiatFormatted } = useMoneyAccountBalance(); | ||
| const { totalFiatFormatted, totalFiatRaw } = useMoneyAccountBalance(); |
There was a problem hiding this comment.
The Add funds bottom sheet designs show the third option as "Add your $X.XX mUSD from your balance. This should be the selected EVM account's mUSD since the CHOMP API automatically sweeps the Money account's mUSD into the Veda Vault.
You can access the selected EVM account's mUSD balance using the useMusdBalance hook.
Currently, this is displaying the mUSD + Veda Vault balance for the Money account (already deposited).
| "description_with_amounts_prefix": "Convert your {{total}} in assets and you could earn up to", | ||
| "description_with_amounts_suffix": "in one year.", | ||
| "convert": "Convert", | ||
| "convert": "Add", |
There was a problem hiding this comment.
| "convert": "Add", | |
| "add": "Add", |
…ale key - MoneyHomeView mUSD subtitle now sources the selected EVM account's mUSD fiat balance via useMusdBalance.fiatBalanceAggregatedFormatted instead of the Money Account aggregate. The Money Account's mUSD is auto-swept into the Veda Vault by CHOMP, so its surface-level balance would have been near-zero in practice. - MoneyAddMoneySheet "Add your \$X mUSD" row uses the same selected EVM account source for both the gate and the amount label. - Rename locale key money.potential_earnings.convert -> potential_earnings.add to match its display value, with call-site updates in PotentialEarningsTokenRow and the surrounding tests.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a21d606. Configure here.
… add-money sheet Gate the move-mUSD row on hasMusdBalanceOnAnyChain so a user with mUSD tokens isn't blocked from moving them just because conversion rates haven't loaded. When rates are unavailable, the label falls back to the raw token amount formatted to 2 decimals so it reads "Add your 42.50 mUSD" instead of "Add your $0.00 mUSD".
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
The SmokeMoney tag covers Card home, Add Funds flows, and ramps - all directly affected by these changes. The MoneyAddMoneySheet changes (label changes) are tested by the card-home-add-funds.spec.ts test. No changes to core controllers, navigation infrastructure, shared components, or other feature areas. No performance-sensitive code paths were modified (no list rendering changes, no new API calls, no state management changes). Performance Test Selection: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #30437 +/- ##
========================================
Coverage 82.03% 82.03%
========================================
Files 5454 5461 +7
Lines 145830 146149 +319
Branches 33411 33515 +104
========================================
+ Hits 119629 119900 +271
- Misses 18016 18032 +16
- Partials 8185 8217 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Description
Applies the seven design-review polishes called out for MUSD-827 on the Money Account Home surface:
MoneyMusdTokenRowsubtitle on Home now reads${balance} • mUSDinstead of justmUSD. The row consumes the existinguseMoneyAccountBalancehook'smusdFiatFormattedfield (spendable mUSD only — not the aggregated total).convertso call sites are untouched.MoneyAddMoneySheetis hidden when the user has no mUSD balance (totalFiatRawnon-positive or unparseable). An unparseable value fails open and keeps the row visible.move_musd_no_amountkey is removed fromen.json.MoneyHowItWorksViewdescription 1 is updated to mention "curated by Veda and Steakhouse Financial" and to drop the em dash; a new description 3 paragraph "Money account is powered by Monad." renders after description 2.MoneyCondensedInfoCardsswapsmm_how_it_works.pngfor the new green bar-chart icon exported from Figma (committed separately at the top of the branch asc3b1fc37af).Items 6, 7, and 9 from the parent design review are intentionally out of scope (handled by MUSD-824, ticketed separately, and out-of-scope per design direction respectively).
Only
locales/languages/en.jsonis touched — non-English translations come from the localization pipeline.Changelog
CHANGELOG entry: Polished the Money Account Home with the spendable mUSD balance in the token row subtitle, a "No fee" badge and "Add" button on Earn Crypto rows, a hidden "Add your $X mUSD" entry on the Add money sheet when the balance is zero, a refreshed "How it works" description and a new Monad attribution paragraph, and an updated How It Works tile image.
Related issues
Fixes: MUSD-827
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Performance checks (if applicable)
Pre-merge reviewer checklist
Note
Medium Risk
Primarily UI copy/label updates, but it also changes when the Add Money sheet shows the mUSD move/add option based on parsed balances, which could hide a user action if balance/rates are miscomputed.
Overview
Polishes Money surfaces around mUSD and Earn Crypto CTAs: the Money Home mUSD row now displays a formatted spendable balance in its subtitle (via
useMusdBalance), and per-token Earn Crypto actions/badges switch to “Add” and “No fee”.Updates the Add Money sheet to source balances from
useMusdBalance, hide the mUSD move/add row when the user has no balance, and format the label as “Add your {amount} mUSD” (falling back to token amount when fiat rates are unavailable). The How It Works screen copy is refreshed and adds a third description paragraph attributing Monad; tests anden.jsonstrings are updated accordingly.Reviewed by Cursor Bugbot for commit c2ea309. Bugbot is set up for automated code reviews on this repo. Configure here.