fix: send amount page header display when modal is opened#30433
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## send_network_alert #30433 +/- ##
=====================================================
Coverage ? 82.03%
=====================================================
Files ? 5457
Lines ? 145902
Branches ? 33431
=====================================================
Hits ? 119697
Misses ? 18015
Partials ? 8190 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
This component is used in the send flow (amount-alerts.tsx and recipient.tsx) to display warning/alert modals when sending tokens. The change is a UI rendering fix that could affect how the alert modal appears during send transactions. SmokeConfirmations is the appropriate tag as it covers transaction sending flows (ETH, ERC-20, Solana SPL tokens) and the send flow where this alert modal appears. No other flows are impacted - this is isolated to the send alert modal within confirmations. No performance tests are needed as this is a simple modal wrapper change with no data loading, state management, or rendering performance implications. Performance Test Selection: |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a6d804f. Configure here.
|
Before:
After:
Note
Low Risk
Low risk UI-layer change that only affects how the send alert bottom sheet is presented; main risk is regressions in modal stacking/close behavior on iOS/Android.
Overview
Fixes the send flow alert UI by presenting
SendAlertModalas a nativeModalwith a design-systemBottomSheet, rather than rendering the bottom sheet directly.This changes the alert’s presentation layer to avoid underlying header/layout artifacts when the sheet is open, while keeping the alert content and footer actions the same.
Reviewed by Cursor Bugbot for commit a6d804f. Bugbot is set up for automated code reviews on this repo. Configure here.