test: stabilize RemoteImage load tests#30424
Merged
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR stabilizes the RemoteImage unit tests by removing reliance on expo-image’s shared mock behavior and making image load (and IPFS URL resolution) deterministic within the test suite.
Changes:
- Adds a local, passive
expo-imagemock to prevent timer-driven auto-onLoadbehavior from affecting assertions. - Makes IPFS URL resolution “pending by default” in tests, with explicit overrides in IPFS-focused cases.
- Replaces direct
image.props.onLoad(...)calls with explicitfireEvent(..., 'load', ...)dispatches and removes now-unneeded fake-timer usage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
juanmigdr
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Stabilizes the
RemoteImageunit tests by making mocked image load events explicit in the test file.The previous setup could let the shared
expo-imagemock fire a timer-driven default load during tests. This change uses a passive local image mock, keeps unrelated IPFS resolution pending by default, and dispatches image load events throughfireEvent.Changelog
CHANGELOG entry: null
Related issues
Fixes: N/A
Manual testing steps
Verification run:
Screenshots/Recordings
N/A. Test-only change.
Before
N/A.
After
N/A.
Pre-merge author checklist
Performance checks (if applicable)
Pre-merge reviewer checklist