Skip to content

chore: Abstract version bump and commit into re-usable workflows and remove ephemeral branch#30418

Merged
Cal-L merged 7 commits into
mainfrom
chore/abstract-version-bump-and-commit-from-workflows
May 20, 2026
Merged

chore: Abstract version bump and commit into re-usable workflows and remove ephemeral branch#30418
Cal-L merged 7 commits into
mainfrom
chore/abstract-version-bump-and-commit-from-workflows

Conversation

@Cal-L

@Cal-L Cal-L commented May 20, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

To simplify workflows, we can remove the ephemeral branches used while version bumping and replace it with version bumps within the workflow itself. No need to manage separate branches. We can also take this opportunity to modularize the concerns associated with:

  • Version bumping
  • Version bump commiting
  • Building the app

These abstractions will allow us to scale as new scenarios are introduced into workflows as well as support our existing workflows that depend on version bumping capabilities

Changelog

CHANGELOG entry:

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MCWP-619

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Refactors release/build GitHub Actions workflows to change how version bumps are generated/committed and when they are applied, which can impact all CI build/release pipelines if misconfigured.

Overview
Refactors CI build pipelines to remove ephemeral build branches and the in-build version-bump step, replacing them with two reusable workflows: generate-build-version.yml (fetch next build number) and commit-build-version.yml (apply/commit/push a provided build number).

Updates build.yml to accept an optional build_number and apply it locally on runners (no commit) when building from an unbumped ref, and rewires RC/prod/runway/nightly/TestFlight/BrowserStack workflows to use the new generate/commit flow and reduced contents permissions. Cleans up legacy workflows (create-build-branch.yml, create-release-pr-legacy.yml) and simplifies TestFlight upload inputs by dropping build_branch.

Reviewed by Cursor Bugbot for commit 26eaefe. Bugbot is set up for automated code reviews on this repo. Configure here.

@Cal-L Cal-L requested review from a team as code owners May 20, 2026 02:19
@github-actions

github-actions Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels May 20, 2026
@metamaskbotv2 metamaskbotv2 Bot added the team-mobile-platform Mobile Platform team label May 20, 2026
@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue May 20, 2026
@Cal-L Cal-L added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed no changelog required No changelog entry is required for this change labels May 20, 2026
cursor[bot]
cursor Bot reviewed May 20, 2026
View reviewed changes
Comment thread .github/workflows/create-release-pr-legacy.yml Outdated
@github-actions github-actions Bot added size-L and removed size-M labels May 20, 2026
cursor[bot]
cursor Bot reviewed May 20, 2026
View reviewed changes
Comment thread .github/workflows/create-release-pr.yml
@sonarqubecloud

sonarqubecloud Bot commented May 20, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Cal-L Cal-L force-pushed the chore/abstract-version-bump-and-commit-from-workflows branch from a8cf7ec to c03b3f3 Compare May 20, 2026 16:01
cursor[bot]
cursor Bot reviewed May 20, 2026
View reviewed changes
Comment thread .github/workflows/build-android.yml
@github-actions

github-actions Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
All 18 changed files are CI/CD infrastructure files (.github/workflows/ and .github/CODEOWNERS). The changes are a pure build pipeline refactoring:

  1. No app source code changes: Zero changes to any application code, controllers, components, or runtime behavior.

  2. No E2E test infrastructure changes: No changes to tests/ directory, page objects, fixtures, or Detox configuration.

  3. Nature of changes: This PR refactors the build version management approach:

    • Replaces ephemeral branch creation (create-build-branch.yml) with local build number application
    • Splits update-latest-build-version.yml into generate-build-version.yml + commit-build-version.yml
    • Removes skip_version_bump parameter from build workflows
    • Reduces permissions from contents: write to contents: read where appropriate
    • Deletes legacy workflows (create-build-branch.yml, create-release-pr-legacy.yml)
    • Updates CODEOWNERS to reflect new workflow names

  4. Impact on E2E tests: None. These workflows govern how builds are versioned and packaged, not how tests run. The BrowserStack upload workflows only had skip_version_bump: true removed (a now-deleted parameter), which has no effect on test execution.

  5. No performance impact: No changes to UI rendering, data loading, state management, or any code path that could affect app performance metrics.

Running E2E tests would provide no validation value for these purely CI/CD infrastructure changes.

Performance Test Selection:
No application code changes were made. All changes are CI/CD workflow files that govern build versioning and pipeline mechanics. There is no impact on app rendering, data loading, state management, or any performance-sensitive code paths.

View GitHub Actions results

andrepimenta
andrepimenta previously approved these changes May 20, 2026
View reviewed changes
@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue May 20, 2026
@Cal-L Cal-L merged commit 0eec0db into main May 20, 2026
19 checks passed
@Cal-L Cal-L deleted the chore/abstract-version-bump-and-commit-from-workflows branch May 20, 2026 16:37
@github-project-automation github-project-automation Bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue May 20, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators May 20, 2026
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 20, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.79.0 Issue or pull request that will be included in release 7.79.0 label May 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@weitingsun weitingsun weitingsun approved these changes

@andrepimenta andrepimenta andrepimenta left review comments

Assignees

No one assigned

Labels

no changelog required No changelog entry is required for this change No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.79.0 Issue or pull request that will be included in release 7.79.0 size-L team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Cal-L @andrepimenta @weitingsun