test: convert ramps e2e to cv by cortisiko · Pull Request #30417 · MetaMask/metamask-mobile

cortisiko · 2026-05-20T01:41:06Z

Description

Adds new component-view test coverage for Ramps flows, including Aggregator (V1) BuildQuote/Quotes and V2 unified-buy BuildQuote, validating deeplink params, token/payment selection, account switching, settings→order-history navigation, and quote fetching.

Introduces Ramp-specific component-view infrastructure: nock-based Ramp SDK API mocking (tests/component-view/api-mocking/ramp.ts), new ramps state presets/fixtures (tests/component-view/presets/ramps.ts), and reusable renderers that mount Ramp screens with modal routes + react-query (tests/component-view/renderers/ramps.tsx). Updates shared test scaffolding to support these flows (nock localhost allowlist behavior, Engine mocks for RampsController.getQuotes and account-tree selection).

Removes several legacy e2e/spec files that previously covered these ramps scenarios.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

I've tested on Android
- Ideally on a mid-range device; emulator is acceptable
I've tested with a power user scenario
- Use these power-user SRPs to import wallets with many accounts and tokens
I've instrumented key operations with Sentry traces for production performance metrics
- See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: changes are primarily test infrastructure and new component-view coverage; production code changes are limited to swapping hardcoded testIDs to shared constants.

Overview
Adds new component-view test suites for Ramp Aggregator BuildQuote/Quotes and V2 unified-buy BuildQuote, covering deeplink initialization, token/payment selection, account switching, settings→order-history navigation, and quote-fetching behavior.

Introduces Ramp-focused component-view infrastructure: nock-based Ramp SDK HTTP mocking (tests/component-view/api-mocking/ramp.ts), reusable render helpers that mount Ramp screens with modal routes + react-query (tests/component-view/renderers/ramps.tsx), and state presets/fixtures for common ramp scenarios (tests/component-view/presets/ramps.ts).

Cleans up legacy Detox/e2e ramps specs (including previously failing/skipped suites) and tweaks shared test scaffolding (disableNetConnect localhost allowlist, additional Engine controller mocks). Also standardizes a couple of UI testIDs via constants (NavbarSelectorsIDs.DEPOSIT_CONFIGURATION_BUTTON, BUILD_QUOTE_TEST_IDS.PAYMENT_PILL).

^{Reviewed by Cursor Bugbot for commit 59bdbe2. Bugbot is set up for automated code reviews on this repo. Configure here.}

…actice

amitabh94

Minor comment but otherwise LGTM

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 59bdbe2. Configure here.}

github-actions · 2026-05-21T14:40:39Z

🔍 Smart E2E Test Selection

Selected E2E tags: SmokeMoney
Selected Performance tags: None (no tests recommended)
Risk Level: low
AI Confidence: 88%

click to see 🤖 AI reasoning details

E2E Test Selection:
The changes in this PR are primarily:

Cosmetic refactors in app code: Two hardcoded test ID strings replaced with constants ("build-quote-payment-pill" → BUILD_QUOTE_TEST_IDS.PAYMENT_PILL and 'deposit-configuration-menu-button' → NavbarSelectorsIDs.DEPOSIT_CONFIGURATION_BUTTON). The actual string values remain identical, so no E2E tests that reference these IDs will break.
Deleted E2E tests: Five test files removed — all were either already skipped (describe.skip) or marked as .failing.ts, meaning they weren't running in CI anyway. Their removal has no impact on test coverage.
New component-view (unit) tests: New test infrastructure (tests/component-view/api-mocking/ramp.ts, presets/ramps.ts, renderers/ramps.tsx) and new .view.test.tsx files for BuildQuote (both V1 Aggregator and V2) and Quotes screens. These are Jest unit tests, not Detox E2E tests.
Test infrastructure improvements: Fixed nock v14 compatibility in nockHelpers.ts, added more mock stubs to mocks.ts for RampsController and GasFeeController.

Risk assessment: Low risk. No functional app logic changed. The ramps/buy/sell flow is the only area touched, warranting SmokeMoney to validate the ramps UI still works correctly with the refactored test IDs. No other flows are affected — Navbar change is isolated to the deposit configuration button in the ramps context, and the deleted tests were non-functional anyway.

Performance Test Selection:
No performance-sensitive changes. The app code changes are purely cosmetic refactors (string constants), and all other changes are test infrastructure (component-view mocks, presets, renderers). No UI rendering, data loading, state management, or critical user flow performance is affected.

View GitHub Actions results

sonarqubecloud · 2026-05-21T14:59:48Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codecov-commenter · 2026-05-21T14:59:51Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.24%. Comparing base (de8a354) to head (59bdbe2).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #30417      +/-   ##
==========================================
+ Coverage   82.14%   82.24%   +0.10%     
==========================================
  Files        5490     5494       +4     
  Lines      147805   148107     +302     
  Branches    33992    34074      +82     
==========================================
+ Hits       121412   121813     +401     
+ Misses      18084    18002      -82     
+ Partials     8309     8292      -17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

test: convert ramps e2e to cv

63999e0

metamaskbotv2 Bot added the team-qa QA team label May 20, 2026

github-actions Bot added the size-L label May 20, 2026

cortisiko marked this pull request as ready for review May 20, 2026 16:09

Merge branch 'main' into MMQA-1763

cedf224

cortisiko requested review from a team as code owners May 20, 2026 16:09

fix linting

c2782c0

cursor Bot reviewed May 20, 2026

View reviewed changes

Comment thread tests/component-view/api-mocking/nockHelpers.ts Outdated

cortisiko added 3 commits May 20, 2026 16:48

update tests

7848cb6

remove redundant ramps regression tests

9c5ec8d

remove deep link e2e in smoke

b8555f9

github-actions Bot added size-XL and removed size-L labels May 20, 2026

cortisiko added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed no changelog required No changelog entry is required for this change labels May 20, 2026

address cursor

27f77b0

cursor Bot reviewed May 20, 2026

View reviewed changes

Comment thread app/components/UI/Ramp/Views/BuildQuote/BuildQuote.view.test.tsx Outdated

Comment thread app/components/UI/Ramp/Views/BuildQuote/BuildQuote.view.test.tsx Outdated

clean up test

9cc5728

cursor Bot reviewed May 20, 2026

View reviewed changes

Comment thread tests/component-view/renderers/ramps.tsx

Comment thread app/components/UI/Ramp/Views/BuildQuote/BuildQuote.view.test.tsx Outdated

adress more cursor feedback and structure tests to confirm to best pr…

417ccd4

…actice

amitabh94 reviewed May 20, 2026

View reviewed changes

Comment thread app/components/UI/Ramp/Views/BuildQuote/BuildQuote.view.test.tsx Outdated

amitabh94 previously approved these changes May 20, 2026

View reviewed changes

chrisleewilcox previously approved these changes May 20, 2026

View reviewed changes

cortisiko added this pull request to the merge queue May 21, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 21, 2026

cortisiko added 2 commits May 20, 2026 23:04

Merge branch 'main' into MMQA-1763

797c345

fix flake

3b2b291

cortisiko dismissed stale reviews from chrisleewilcox and amitabh94 via 3b2b291 May 21, 2026 03:20