Skip to content

feat: add AI disclaimer to whats happening cp-7.78.0#30352

Merged
joaosantos15 merged 1 commit into
mainfrom
TSA-539-add-ai-disclaimer-whats-happening
May 19, 2026
Merged

feat: add AI disclaimer to whats happening cp-7.78.0#30352
joaosantos15 merged 1 commit into
mainfrom
TSA-539-add-ai-disclaimer-whats-happening

Conversation

@joaosantos15

@joaosantos15 joaosantos15 commented May 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Adds a disclaimer to the Market Insights page when the AI button is clicked.

Changelog

CHANGELOG entry: no-changelog

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk UI-only change that adds a new bottom-sheet visibility state and callback wiring; primary risk is minor regressions in the Whats Happening detail view interaction flow.

Overview
Adds an AI disclaimer flow to the What's happening detail carousel: tapping the AI pill on WhatsHappeningExpandedCard now triggers an onAIDisclaimerPress callback, which WhatsHappeningDetailView uses to show/hide MarketInsightsDisclaimerBottomSheet.

Updates unit tests to cover the new AI-pill press behavior and bottom sheet open/close rendering logic.

Reviewed by Cursor Bugbot for commit 026dd93. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented May 19, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@joaosantos15 joaosantos15 added the team-social-ai Social & AI team label May 19, 2026
@github-actions

github-actions Bot commented May 19, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeWalletPlatform
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are confined to the WhatsHappeningDetailView and its WhatsHappeningExpandedCard component. The key changes are:

  1. The AI pill in WhatsHappeningExpandedCard was a static Box and is now a Pressable with an onAIDisclaimerPress callback, press feedback, accessibility attributes, and a testID.
  2. WhatsHappeningDetailView adds the MarketInsightsDisclaimerBottomSheet, state management for its visibility, and passes the handler down to WhatsHappeningExpandedCard.

These are UI-only changes within the Trending/WhatsHappening feature. The WhatsHappeningDetailView is part of the Trending tab, which is covered by SmokeWalletPlatform. The trending-feed.spec.ts test navigates to detail views (perps, tokens, predictions) which render WhatsHappeningExpandedCard — so these tests are the most relevant for validating the changes don't break existing card rendering.

No controller changes, no navigation infrastructure changes, no shared components (TabBar, modals used across the app) are affected. The MarketInsightsDisclaimerBottomSheet is a new addition but is only rendered conditionally when the AI pill is tapped. No other tags (SmokeConfirmations, SmokePerps, etc.) are needed as the change doesn't affect transaction flows, perps trading logic, or other cross-cutting concerns.

Performance Test Selection:
The changes are purely UI additions (making an AI pill pressable and adding a conditional bottom sheet). There is no impact on rendering performance, data loading, state management, or any performance-sensitive paths. No performance tests are warranted.

View GitHub Actions results

@joaosantos15 joaosantos15 enabled auto-merge May 19, 2026 08:04
@sonarqubecloud

sonarqubecloud Bot commented May 19, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@joaosantos15 joaosantos15 added this pull request to the merge queue May 19, 2026
Merged via the queue into main with commit 5efac50 May 19, 2026
198 of 223 checks passed
@joaosantos15 joaosantos15 deleted the TSA-539-add-ai-disclaimer-whats-happening branch May 19, 2026 09:08
@github-actions github-actions Bot locked and limited conversation to collaborators May 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@xavier-brochard xavier-brochard xavier-brochard approved these changes

Assignees

No one assigned

Labels

size-M team-social-ai Social & AI team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joaosantos15 @xavier-brochard