Skip to content

chore(runway): cherry-pick chore: ohlcv reduce initial delay cp-7.78.0#30312

Merged
chloeYue merged 1 commit into
release/7.78.0from
runway-cherry-pick-7.78.0-1779112661
May 18, 2026
Merged

chore(runway): cherry-pick chore: ohlcv reduce initial delay cp-7.78.0#30312
chloeYue merged 1 commit into
release/7.78.0from
runway-cherry-pick-7.78.0-1779112661

Conversation

@runway-github

@runway-github runway-github Bot commented May 18, 2026

Copy link
Copy Markdown
Contributor

Description

Problem

Chart data took ~9-10 seconds to display after navigating to token
details. Performance logs showed it takes approximately 9.4 seconds from
WebSocket subscription until the first bar update arrives from the
server.

Solution

Implemented immediate REST API polling to provide data while waiting for
the first WebSocket update:

  1. Reduced staleness threshold from 10s to 5s
  2. Added immediate data fetch via REST API right after WebSocket
    subscription

Timeline Observed

T=0ms     - Subscribe to WebSocket
T=~300ms  - First REST data arrives (immediate!)
T=5s      - Second REST poll (WebSocket not ready yet)
T=9.4s    - First WebSocket update arrives, REST polling stops
T=14.4s+  - WebSocket continues with regular updates (~5s intervals)

Changelog

CHANGELOG entry: OHLCV chart data now loads in ~300ms via REST API while
establishing WebSocket connection, reducing initial load time from 9.4s
to 300ms.

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
  • Use these power-user
    SRPs

    to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production
    performance metrics
  • See trace() for usage and
    addToken
    for an example

For performance guidelines and tooling, see the Performance
Guide
.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Medium Risk
Changes chart data fetching timing by triggering immediate REST polls
and a shorter staleness threshold, which could increase network traffic
or cause unexpected polling behavior if timing assumptions are wrong.

Overview
Reduces perceived OHLCV chart load time by polling the /latest
REST endpoint immediately after a successful WebSocket subscribe
,
instead of waiting for the first WS bar.

Shortens the WS staleness threshold from 10s to 5s, tweaks stale
detection to use >=, and adds basic numeric validation in
fetchLatestBar to drop malformed REST responses. Tests are updated to
reflect the new timing and the additional initial REST fetch (many cases
now expect two fetch calls: immediate + staleness/chain-down).

Reviewed by Cursor Bugbot for commit
a3d5c11. Bugbot is set up for automated
code reviews on this repo. Configure
here.

[cd875d0](https://github.com/MetaMask/metamask-mobile/commit/cd875d06f7cfb70245c0454616991b4ab95186f0)

#30292)

## **Description**

## Problem
Chart data took ~9-10 seconds to display after navigating to token
details. Performance logs showed it takes approximately 9.4 seconds from
WebSocket subscription until the first bar update arrives from the
server.

## Solution
Implemented immediate REST API polling to provide data while waiting for
the first WebSocket update:

1. **Reduced staleness threshold** from 10s to 5s
2. **Added immediate data fetch** via REST API right after WebSocket
subscription

## Timeline Observed
```
T=0ms     - Subscribe to WebSocket
T=~300ms  - First REST data arrives (immediate!)
T=5s      - Second REST poll (WebSocket not ready yet)
T=9.4s    - First WebSocket update arrives, REST polling stops
T=14.4s+  - WebSocket continues with regular updates (~5s intervals)
```

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: OHLCV chart data now loads in ~300ms via REST API while
establishing WebSocket connection, reducing initial load time from 9.4s
to 300ms.

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

<!--
Every checklist item must be consciously assessed before marking this PR
as
"Ready for review". A checked box means you deliberately considered that
responsibility, not that you literally performed every action listed.

Unchecked boxes are ambiguous: they are not an implicit "N/A" and they
are not
a silent "skip". See `docs/readme/ready-for-review.md` for the full
checklist
semantics.
-->

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

#### Performance checks (if applicable)

- [ ] I've tested on Android
  - Ideally on a mid-range device; emulator is acceptable
- [ ] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example

For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).

## **Pre-merge reviewer checklist**

<!--
Reviewer checklist items follow the same semantics as the author
checklist: an
unchecked box is ambiguous, a checked box means the reviewer consciously
assessed that responsibility. See `docs/readme/ready-for-review.md`.
-->

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Changes chart data fetching timing by triggering immediate REST polls
and a shorter staleness threshold, which could increase network traffic
or cause unexpected polling behavior if timing assumptions are wrong.
> 
> **Overview**
> Reduces perceived OHLCV chart load time by **polling the `/latest`
REST endpoint immediately after a successful WebSocket subscribe**,
instead of waiting for the first WS bar.
> 
> Shortens the WS staleness threshold from `10s` to `5s`, tweaks stale
detection to use `>=`, and adds basic numeric validation in
`fetchLatestBar` to drop malformed REST responses. Tests are updated to
reflect the new timing and the additional initial REST fetch (many cases
now expect **two** `fetch` calls: immediate + staleness/chain-down).
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
a3d5c11. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - PR targets a release branch (release/*)

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@chloeYue chloeYue merged commit 18938d3 into release/7.78.0 May 18, 2026
195 of 204 checks passed
@chloeYue chloeYue deleted the runway-cherry-pick-7.78.0-1779112661 branch May 18, 2026 16:18
@github-actions github-actions Bot locked and limited conversation to collaborators May 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants