Skip to content

chore(runway): cherry-pick fix: release-blocker restore gas estimate alerts cp-7.78.0#30311

Merged
chloeYue merged 1 commit into
release/7.78.0from
runway-cherry-pick-7.78.0-1779112649
May 18, 2026
Merged

chore(runway): cherry-pick fix: release-blocker restore gas estimate alerts cp-7.78.0#30311
chloeYue merged 1 commit into
release/7.78.0from
runway-cherry-pick-7.78.0-1779112649

Conversation

@runway-github

@runway-github runway-github Bot commented May 18, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes release blocker regression
#30260 for release
7.78.0

Changelog

CHANGELOG entry: restores gas estimate alerts on all networks except
strictly gas-sponsored ones

Related issues

Fixes: #30260

Manual testing steps

Same testing intructions as for
#29835
Add non-regression for issues raised in
#30260, which may
include for example calling pause on Mainnet
USDC

and checking that the "gas estimation failed" alert shows at least
somewhere (can be second alert, but it needs to exist).

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
  • Use these power-user
    SRPs

    to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production
    performance metrics
  • See trace() for usage and
    addToken
    for an example

For performance guidelines and tooling, see the Performance
Guide
.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Medium Risk
Changes confirmation alert gating logic for gas estimation failures
and sponsorship reserve warnings, which could alter what users see
during transaction approval on different networks. Risk is moderate
because it affects transaction UX/decisioning but does not change
signing or on-chain behavior.

Overview
Restores and tightens when gas-related confirmation alerts are shown
by introducing useIsGasSponsored, which returns true only when
both the gasless transaction is supported and the current chain is
enabled via the gasFeesSponsoredNetwork feature flag.

useGasEstimateFailedAlert now suppresses the “gas estimate failed”
warning only when useIsGasSponsored is true (instead of suppressing
for any gasless-supported/pending checks), and
useGasSponsorshipWarningAlert now shows the Monad reserve-balance
blocking warning only when sponsorship is expected for the transaction.
Tests were updated and a new unit test suite was added for
useIsGasSponsored.

Reviewed by Cursor Bugbot for commit
d06ea89. Bugbot is set up for automated
code reviews on this repo. Configure
here.

[ac8df0d](https://github.com/MetaMask/metamask-mobile/commit/ac8df0d53eb78845185d6a54ba58fd772951e29f)

…alerts cp-7.78.0 (#30266)

<!--
Please submit this PR as a draft initially.

Do not mark it as "Ready for review" until this PR meets the canonical
Definition of Ready For Review in `docs/readme/ready-for-review.md`.

In short: the template must be materially complete (not just section
titles
present), all status checks must be currently passing, and the only
expected
follow-up commits must be reviewer-driven.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

Fixes release blocker regression
#30260 for release
7.78.0

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: restores gas estimate alerts on all networks except
strictly gas-sponsored ones

## **Related issues**

Fixes: #30260

## **Manual testing steps**

Same testing intructions as for
#29835
Add non-regression for issues raised in
#30260, which may
include for example calling `pause` on [Mainnet
USDC](https://etherscan.io/token/0xa0b86991c6218b36c1d19d4a2e9eb0ce3606eb48#writeProxyContract)
and checking that the "gas estimation failed" alert shows at least
somewhere (can be second alert, but it needs to exist).

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

<!--
Every checklist item must be consciously assessed before marking this PR
as
"Ready for review". A checked box means you deliberately considered that
responsibility, not that you literally performed every action listed.

Unchecked boxes are ambiguous: they are not an implicit "N/A" and they
are not
a silent "skip". See `docs/readme/ready-for-review.md` for the full
checklist
semantics.
-->

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

#### Performance checks (if applicable)

- [ ] I've tested on Android
  - Ideally on a mid-range device; emulator is acceptable
- [ ] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example

For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).

## **Pre-merge reviewer checklist**

<!--
Reviewer checklist items follow the same semantics as the author
checklist: an
unchecked box is ambiguous, a checked box means the reviewer consciously
assessed that responsibility. See `docs/readme/ready-for-review.md`.
-->

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Changes confirmation alert gating logic for gas estimation failures
and sponsorship reserve warnings, which could alter what users see
during transaction approval on different networks. Risk is moderate
because it affects transaction UX/decisioning but does not change
signing or on-chain behavior.
> 
> **Overview**
> Restores and tightens when gas-related confirmation alerts are shown
by introducing `useIsGasSponsored`, which returns true only when
**both** the gasless transaction is supported and the current chain is
enabled via the `gasFeesSponsoredNetwork` feature flag.
> 
> `useGasEstimateFailedAlert` now suppresses the “gas estimate failed”
warning only when `useIsGasSponsored` is true (instead of suppressing
for any gasless-supported/pending checks), and
`useGasSponsorshipWarningAlert` now shows the Monad reserve-balance
blocking warning only when sponsorship is expected for the transaction.
Tests were updated and a new unit test suite was added for
`useIsGasSponsored`.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
d06ea89. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@runway-github runway-github Bot requested a review from a team as a code owner May 18, 2026 13:57
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - PR targets a release branch (release/*)

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@chloeYue chloeYue merged commit f2f4f4f into release/7.78.0 May 18, 2026
260 of 270 checks passed
@chloeYue chloeYue deleted the runway-cherry-pick-7.78.0-1779112649 branch May 18, 2026 17:56
@github-actions github-actions Bot locked and limited conversation to collaborators May 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants