Skip to content

chore: related assets pills with price change cp-7.78.0#30259

Merged
zone-live merged 8 commits into
mainfrom
TSA-related-assets-as-pills
May 18, 2026
Merged

chore: related assets pills with price change cp-7.78.0#30259
zone-live merged 8 commits into
mainfrom
TSA-related-assets-as-pills

Conversation

@zone-live

@zone-live zone-live commented May 15, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Adds the related assets as pills with price variation, in a sliding carousel. When the user taps a pill, it will redirect to the asset perps page.
Also fires the segment WHATS_HAPPENING_INTERACTED / related_asset_pressed analytics event on tap.

Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-05-15.at.15.09.51.mov

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Adds new interactive UI inside the What's Happening carousel that subscribes to live perps price streams and triggers trade navigation + analytics on tap, which can impact performance and event accuracy if miswired.

Overview
Adds a horizontal “related assets” pill slider to each WhatsHappeningCard, replacing the prior single “<symbol> +N” label and moving the date display to the top row alongside the impact badge.

Each pill can optionally show 24h % change from live perps prices, and when tradable is pressable to open perps trade navigation while emitting a new analytics interaction type related_asset_pressed (MetaMetricsEvents.WHATS_HAPPENING_INTERACTED).

To support live pricing, the homepage WhatsHappeningSection carousel is now wrapped in PerpsStreamProvider, and useWhatsHappeningAssetPrices is refactored to accept RelatedAsset[] directly (with tests updated/added for the new pill/slider behavior and updated skeleton layout).

Reviewed by Cursor Bugbot for commit 77b44dd. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label May 15, 2026
@zone-live zone-live added team-social-ai Social & AI team and removed pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. labels May 15, 2026
cursor[bot]
cursor Bot reviewed May 15, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 59d293d. Configure here.

Comment thread app/components/UI/WhatsHappening/components/WhatsHappeningCard.test.tsx
@github-actions

github-actions Bot commented May 18, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeWalletPlatform, SmokePerps, SmokeConfirmations
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 78%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changed files are all part of the "What's Happening" feature — an AI-powered news/market insights section with cards, asset pills, and live perps price integration.

Key impact areas:

  1. SmokeWalletPlatform: WhatsHappeningSection is embedded in TrendingView/tabs/NowTab.tsx, which is part of the Trending tab. The trending-feed.spec.ts test (tagged SmokeWalletPlatform) tests the Trending tab including its sections. Changes to the WhatsHappening cards/section could affect the Trending feed rendering and navigation.

  2. SmokePerps: WhatsHappeningSection is also embedded in PerpsHomeView.tsx. The WhatsHappeningAssetPill uses useTradeNavigation to navigate to perps trading. The useWhatsHappeningAssetPrices hook integrates with perps live WebSocket price streams. Changes here could affect the Perps home view and asset pill trade navigation.

  3. SmokeConfirmations: Per the SmokePerps tag description, when selecting SmokePerps, also select SmokeConfirmations since Add Funds deposits are on-chain transactions. The asset pill trade navigation can also trigger trade flows that involve confirmations.

No E2E tests directly reference WhatsHappening — there are no dedicated WhatsHappening E2E test files. The impact is indirect through the Trending and Perps views that embed this component.

Changes are UI/component level — new components (AssetPill, AssetSlider, CardSkeleton) and modifications to existing ones. The risk is medium since these are feature-level UI changes that don't touch core infrastructure, but they do affect visible surfaces in Trending and Perps views that have E2E coverage.

Performance Test Selection:
The changes are UI component additions/modifications for the WhatsHappening feature. While the AssetSlider uses a throttled WebSocket price stream (3s throttle), this is a feature-level change and not a core performance-critical path like account list rendering, app launch, or login flows. The changes don't affect the performance test scenarios covered by the available performance tags (@PerformanceAccountList, @PerformanceOnboarding, @PerformanceLogin, @PerformanceSwaps, @PerformanceLaunch, @PerformanceAssetLoading, @PerformancePredict, @PerformancePreps).

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented May 18, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@zone-live zone-live added this pull request to the merge queue May 18, 2026
@zone-live zone-live changed the title chore: related assets pills with price change chore: related assets pills with price change cp-7.78.0 May 18, 2026
Merged via the queue into main with commit 2e2cce7 May 18, 2026
380 of 404 checks passed
@zone-live zone-live deleted the TSA-related-assets-as-pills branch May 18, 2026 14:51
@github-actions github-actions Bot locked and limited conversation to collaborators May 18, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.79.0 Issue or pull request that will be included in release 7.79.0 label May 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@joaosantos15 joaosantos15 joaosantos15 approved these changes

Assignees

No one assigned

Labels

release-7.79.0 Issue or pull request that will be included in release 7.79.0 size-L team-social-ai Social & AI team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zone-live @joaosantos15