chore: align carousel card heights for accessibility cp-7.78.0#30201
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit da18d8b. Configure here.
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
These changes affect only the visual layout of the WhatsHappening carousel section, which is part of the Trending discovery tab covered by SmokeWalletPlatform. No logic, navigation, controller, or shared infrastructure changes were made. The risk is low - only the card height behavior changes (from fixed to natural/minimum height). SmokeWalletPlatform is the appropriate tag as it covers the Trending discovery tab where WhatsHappening is displayed. Performance Test Selection: |
|
The committed fixture schema is out of date. To update, comment: |




Description
Use fluid heights on cards so large system text doesn’t clip.
Problem before: fixed heights + large accessibility text scaling = content clipping inside cards.
Now: cards and skeletons are fully fluid (no height prop needed). Only ViewMoreCard keeps a height, and only as a min-h directly inline in WhatsHappeningSection, so it sits at the same height as a typical card at normal font scale.
How it looks now with huge font:
And normal/default font size:

Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Low Risk
Low risk UI/layout change to remove fixed card heights; main risk is minor visual regression in carousel alignment across devices/font scales.
Overview
Makes the What’s Happening carousel cards and loading skeletons fluid-height by removing the fixed Tailwind height prop (
twHeightClassName) fromWhatsHappeningCardandWhatsHappeningCardSkeleton, preventing content clipping with large accessibility text.Keeps the “View more” tile visually aligned by switching it to a
min-h-[230px]constraint, and updates the skeleton test to assert the expected 2-line title and 3-line description placeholder configuration.Reviewed by Cursor Bugbot for commit 00186c9. Bugbot is set up for automated code reviews on this repo. Configure here.