test: fixes corner cases for metrics collection data#30197
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
hjetpoluru
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Tightens the declarative MetaMetrics expectations static scan in
collect-qa-stats.mjsso QA stats include every event naming pattern used undertests/helpers/analytics/expectations/.The
metametricsslice ofqa-stats.jsonis built by regex-parsing expectation modules. Several valid patterns produced no counted event names, so Grafana / coverage metrics understated E2E analytics coverage even when expectations existed.Cases that were previously missed
{ name: SOME_CONST }(no comma before})events: [{ name: CARD_BUTTON_VIEWED }, …]name: Ident,only;}after the identifier did not match.eventNames: [ CONST ], noevents[].namepredict-geo-restriction.analytics.ts(Geo Blocked Triggered)eventNamesarrays were never read; onlyname:, globalonboardingEvents, andconst … = […];with an “event-ish” variable name were.eventNames: [ A, B, … ]as the sole or extra inline listRAMPS_*), opt-out, bridge/swap/predict smoke files, etc.name:, buteventNames-only specs were fully dropped.Not a regression / intentional:
eventNames: [ ...someArray ]— spread segments are ignored here because the referencedconst(e.g.transactionEventNames,expectedEventNames) is still ingested via the existingconst *Names* / event-isharray path.Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
N/A
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Medium Risk
Changes the regex-based static scan that feeds Grafana QA metrics; mistakes could under/over-count events or fail the stats job, impacting CI observability but not app runtime behavior.
Overview
Tightens
.github/scripts/collect-qa-stats.mjsMetaMetrics static scanning soqa-stats.jsoncaptures more valid event-name patterns from declarative*.analytics.tsexpectations.The parser now (1) recognizes
name: SOME_CONSTeven when it is the last field in an object, (2) extracts inlineeventNames: [...]lists using a simple balanced-bracket slice, and (3) centralizes list-token resolution (string literals,onboardingEvents.*, string consts) while skipping spread entries like...someArray.Reviewed by Cursor Bugbot for commit 76bc803. Bugbot is set up for automated code reviews on this repo. Configure here.