Skip to content

chore: spacing fix in Whats happening carousel card#30186

Merged
zone-live merged 6 commits into
mainfrom
TSA-spacing-whats-happening-card
May 14, 2026
Merged

chore: spacing fix in Whats happening carousel card#30186
zone-live merged 6 commits into
mainfrom
TSA-spacing-whats-happening-card

Conversation

@zone-live

@zone-live zone-live commented May 14, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Fixes the spacing in the Whats happening carousel card.

Before:
Screenshot 2026-05-14 at 14 58 30

After:
Screenshot 2026-05-14 at 14 57 57

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk UI-only change that standardizes carousel card/skeleton heights; no business logic, data, or security behavior is modified.

Overview
Adjusts the WhatsHappening carousel to use a shared Tailwind height class (h-[230px]) so real cards, loading skeletons, and the ViewMoreCard stay visually aligned.

Adds an optional twHeightClassName prop to WhatsHappeningCard and WhatsHappeningCardSkeleton, wires it through from WhatsHappeningSection, and includes a small unit test for the skeleton component.

Reviewed by Cursor Bugbot for commit a03dda5. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label May 14, 2026
@metamaskbotv2 metamaskbotv2 Bot added the team-social-ai Social & AI team label May 14, 2026
@github-actions

github-actions Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

cursor[bot]
cursor Bot reviewed May 14, 2026
View reviewed changes
Comment thread app/components/UI/WhatsHappening/components/WhatsHappeningCard.tsx Outdated
@zone-live zone-live removed the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label May 14, 2026
@github-actions github-actions Bot added size-S and removed size-XS labels May 14, 2026
@github-actions

github-actions Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokePerps, SmokeWalletPlatform
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 88%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are purely UI/cosmetic refactoring of the WhatsHappening carousel component:

  1. WhatsHappeningCard.tsx: Added optional twHeightClassName prop (defaults to ''), replacing the hardcoded h-[254px] height class. This allows the parent carousel to control card height.

  2. WhatsHappeningCardSkeleton.tsx: Same pattern — added twHeightClassName prop to allow height to be passed in. Previously the skeleton had no explicit height class.

  3. WhatsHappeningSection.tsx: Introduced a shared CARD_HEIGHT_CLASS = 'h-[230px]' constant and passes it to WhatsHappeningCard, WhatsHappeningCardSkeleton, and ViewMoreCard to ensure visual alignment. Height changed from 254px → 230px.

  4. WhatsHappeningCardSkeleton.test.tsx: New unit test for the skeleton component.

Impact scope:

  • WhatsHappeningSection is directly used in PerpsHomeView (confirmed via grep) → SmokePerps is needed
  • WhatsHappening is also part of the Trending tab in SmokeWalletPlatform → SmokeWalletPlatform is needed
  • Per SmokePerps tag description: "also select SmokeWalletPlatform (Trending section)" — this dependency is explicitly called out
  • No confirmations, account management, network, swap, or other flows are affected
  • The feature is gated by a feature flag, limiting blast radius
  • Changes are purely visual (height refactoring), no logic or state changes

Performance Test Selection:
The changes are purely cosmetic UI adjustments — refactoring a hardcoded height value (254px → 230px) into a shared constant passed as a prop. There are no changes to data fetching, state management, list rendering logic, or any performance-sensitive code paths. No performance tests are warranted.

View GitHub Actions results

cursor[bot]
cursor Bot reviewed May 14, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a03dda5. Configure here.

Comment thread app/components/UI/WhatsHappening/components/WhatsHappeningCardSkeleton.test.tsx
@sonarqubecloud

sonarqubecloud Bot commented May 14, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@zone-live zone-live added this pull request to the merge queue May 14, 2026
Merged via the queue into main with commit 4fdbac9 May 14, 2026
96 checks passed
@zone-live zone-live deleted the TSA-spacing-whats-happening-card branch May 14, 2026 17:03
@github-actions github-actions Bot locked and limited conversation to collaborators May 14, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.78.0 Issue or pull request that will be included in release 7.78.0 label May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@aganglada aganglada aganglada approved these changes

Assignees

No one assigned

Labels

release-7.78.0 Issue or pull request that will be included in release 7.78.0 size-S team-social-ai Social & AI team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zone-live @aganglada