test: removes non used dead code#30179
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3dcbe72. Configure here.
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: Key findings:
The primary risk is that some swap-related tests may have been implicitly relying on the global mock without setting it up themselves. SmokeSwap tests must be run to validate they still work correctly after this change. SmokeConfirmations is included because swap flows involve transaction confirmations per the tag descriptions. Performance Test Selection: |
|




Description
#29587 added code that is test specific oriented and isn't being used. This PR removes this code in order to cleanup FixtureHelper.
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
N/A
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Low Risk
Low risk test-only cleanup: removes an unused option and associated mock wiring, which could only affect E2E tests that implicitly relied on the default swap popular-tokens mock.
Overview
Removes the unused
shouldPrefetchSwapTokensoption fromWithFixturesOptionsand eliminates the correspondingFixtureHelper.withFixturescleanup-time hook that auto-mocked the swap popular-tokens endpoint.E2E tests must now explicitly set up swap token mocks (e.g., via swap-specific test mocks) rather than relying on
withFixturesto preconfigure them.Reviewed by Cursor Bugbot for commit 9918112. Bugbot is set up for automated code reviews on this repo. Configure here.