Skip to content

fix: fix UI nit whats happening#30178

Merged
zone-live merged 3 commits into
mainfrom
TSA-fix-ui-nit-whats-happening
May 14, 2026
Merged

fix: fix UI nit whats happening#30178
zone-live merged 3 commits into
mainfrom
TSA-fix-ui-nit-whats-happening

Conversation

@zone-live

@zone-live zone-live commented May 14, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes the AI pill size and also fixes the Android header overlap by replacing React Native's SafeAreaView (iOS-only) with the one from react-native-safe-area-context, which correctly insets the status bar on Android.

Screenshot 2026-05-14 at 11 54 40 Screenshot 2026-05-14 at 11 56 11

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk UI-only tweaks: swaps SafeAreaView implementation to fix Android status-bar overlap and adjusts pill styling; no business logic or data handling changes.

Overview
Fixes layout issues in the Whats Happening detail screen by replacing React Native’s SafeAreaView with react-native-safe-area-context so the header respects Android status-bar insets.

Tweaks the expanded card’s AI pill styling in dark mode by adding a transparent border, aligning its size/spacing with the light-mode pill.

Reviewed by Cursor Bugbot for commit 4a8a093. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-social-ai Social & AI team label May 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeWalletPlatform, SmokePerps
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 82%
click to see 🤖 AI reasoning details

E2E Test Selection:
The two changed files are in the WhatsHappeningDetailView component:

  1. WhatsHappeningDetailView.tsx: Swaps SafeAreaView import from react-native to react-native-safe-area-context. This is a standard fix for proper safe area inset handling on both iOS and Android. It's a low-risk change but could affect the layout/rendering of the detail view screen.

  2. WhatsHappeningExpandedCard.tsx: Adds border border-transparent to the dark mode AI pill container CSS class. This is a purely cosmetic fix to ensure consistent border rendering in dark mode (matching the light mode which already has a border).

Impact analysis:

  • The WhatsHappening feature is embedded in PerpsHomeView (via WhatsHappeningSection) and in the Trending tab
  • The WhatsHappeningDetailView is registered as a navigation screen in MainNavigator.js
  • These changes are isolated to the WhatsHappening detail view and its expanded card component
  • No controller changes, no shared navigation changes, no logic changes

Tag selection:

  • SmokeWalletPlatform: The Trending tab hosts the WhatsHappening section; changes to views embedded in Trending affect this tag
  • SmokePerps: PerpsHomeView directly renders WhatsHappeningSection; per tag description, Perps views (including PerpsHomeView) affect Trending/SmokeWalletPlatform

Per SmokePerps description: "When selecting SmokePerps, also select SmokeWalletPlatform (Trending section) and SmokeConfirmations (Add Funds deposits are on-chain transactions)." However, since these changes don't touch any transaction/confirmation flows, SmokeConfirmations is not warranted here — the changes are purely UI/layout fixes with no transaction logic involved.

Performance Test Selection:
The changes are minor UI fixes: a SafeAreaView import swap and a CSS class addition for dark mode border consistency. Neither change affects rendering performance, data loading, state management, or any performance-critical paths. No performance tests are warranted.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@zone-live zone-live enabled auto-merge May 14, 2026 11:25
@zone-live zone-live added this pull request to the merge queue May 14, 2026
Merged via the queue into main with commit 04acd1a May 14, 2026
96 checks passed
@zone-live zone-live deleted the TSA-fix-ui-nit-whats-happening branch May 14, 2026 12:09
@github-actions github-actions Bot locked and limited conversation to collaborators May 14, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.78.0 Issue or pull request that will be included in release 7.78.0 label May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.78.0 Issue or pull request that will be included in release 7.78.0 size-XS team-social-ai Social & AI team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants