You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Note
Low Risk
Low code risk since this only disables a failing E2E test, but it reduces CI coverage for Solana wallet-standard message signing until the underlying flake is fixed.
Overview
Skips the Solana Wallet Standard E2E - Sign Message smoke test by changing describe to describe.skip, with a comment linking to the tracking Slack thread, to unblock consistently failing CI runs.
Reviewed by Cursor Bugbot for commit 5647621. Bugbot is set up for automated code reviews on this repo. Configure here.
Selected Performance tags: None (no tests recommended)
Risk Level: low
AI Confidence: 95%
click to see 🤖 AI reasoning details
E2E Test Selection:
The only change is adding describe.skip() to the Solana Wallet Standard sign message test suite, skipping it due to a known issue referenced in a Slack thread. This is a pure test infrastructure change with no app code modifications.
The change is in a SmokeNetworkExpansion-tagged test file. Running SmokeNetworkExpansion is appropriate to verify:
The skip doesn't break the test runner or other tests in the suite
The remaining Solana Wallet Standard tests (connect.spec.ts, transferSol.spec.ts) still pass
SmokeConfirmations is NOT selected because no app confirmation code was changed - this is purely a test skip. No performance tests are needed as no app code was modified.
Performance Test Selection:
No app code was changed - only a test file was modified to skip a test suite. No performance impact possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
no-changelogno-changelog Indicates no external facing user changes, therefore no changelog documentation neededrelease-7.78.0Issue or pull request that will be included in release 7.78.0size-XSteam-qaQA team
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Skips
tests/smoke/multichain/solana-wallet-standard/signMessage.spec.tsas it is failling consistently on CI.Changelog
CHANGELOG entry:
Related issues
Fixes: https://consensys.slack.com/archives/C02U025CVU4/p1778748720677019
Manual testing steps
N/A
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Low Risk
Low code risk since this only disables a failing E2E test, but it reduces CI coverage for Solana wallet-standard message signing until the underlying flake is fixed.
Overview
Skips the
Solana Wallet Standard E2E - Sign Messagesmoke test by changingdescribetodescribe.skip, with a comment linking to the tracking Slack thread, to unblock consistently failing CI runs.Reviewed by Cursor Bugbot for commit 5647621. Bugbot is set up for automated code reviews on this repo. Configure here.