Skip to content

feat: add push pre-prompt sheets (ui only)#30166

Merged
samir-acle merged 3 commits into
mainfrom
GE-217-pre-prompt-for-push-notifications-ui-sheets
May 15, 2026
Merged

feat: add push pre-prompt sheets (ui only)#30166
samir-acle merged 3 commits into
mainfrom
GE-217-pre-prompt-for-push-notifications-ui-sheets

Conversation

@samir-acle

@samir-acle samir-acle commented May 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Adds the push notification pre-prompt bottom sheet UI components for both new and existing users.

This PR includes the presentational sheet components, styles, test IDs, English locale strings, and component tests only. The sheets are not wired into the app flow in this PR; the follow-up PR will add eligibility logic and runtime integration.

designs: https://claude.ai/design/p/0c907d58-17d2-4ee2-a7f6-19e156c72b2b?via=share&file=Push+Notification+Onboarding.html

Changelog

CHANGELOG entry: null

Related issues

Fixes: N/A - split PR for GE-217 UI sheet components only. The final integration PR will close the ticket.

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

NewUser
dark mode
image

light mode
image

ExistingUser
dark mode
image

light mode
image

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@samir-acle samir-acle changed the title feat: add push pre-prompt sheets feat: add push pre-prompt sheets (ui only) May 14, 2026
@samir-acle samir-acle added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label May 14, 2026
@samir-acle samir-acle marked this pull request as ready for review May 14, 2026 15:27
@samir-acle samir-acle requested a review from a team as a code owner May 14, 2026 15:27
@samir-acle samir-acle enabled auto-merge May 14, 2026 15:27
@github-actions

github-actions Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
All 9 changed files are brand new additions with no modifications to existing code:

  1. New components only: ExistingUserSheet and NewUserSheet are newly created bottom sheet components for push notification onboarding. They are not imported anywhere in the existing codebase (confirmed via grep search).

  2. No existing code modified: These are purely additive changes - new files created in a new directory (PushNotificationOnboarding).

  3. Locale changes are additive only: The en.json changes only add new string keys under notifications.push_onboarding.*. No existing strings were modified or removed.

  4. No integration yet: The components exist in isolation - no parent component, screen, or navigation flow imports them yet. They cannot affect any existing user flows.

  5. No shared infrastructure touched: No controllers, Engine, navigation, modals, or shared components were modified.

Since these new components are not yet integrated into any existing flows and no existing code was modified, there are no E2E tests that need to run to validate these changes. The unit tests (ExistingUserSheet.test.tsx and NewUserSheet.test.tsx) cover the component behavior directly.

Performance Test Selection:
No performance-sensitive code was changed. These are new isolated UI components not yet integrated into any flows, with no impact on rendering performance, data loading, state management, or critical user flows.

View GitHub Actions results

@codecov-commenter

codecov-commenter commented May 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.05128% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.82%. Comparing base (3751d9a) to head (5fa232e).
⚠️ Report is 239 commits behind head on main.

Files with missing lines Patch % Lines
...tificationOnboarding/NewUserSheet/NewUserSheet.tsx 81.81% 2 Missing and 2 partials ⚠️
...Onboarding/ExistingUserSheet/ExistingUserSheet.tsx 80.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #30166      +/-   ##
==========================================
+ Coverage   81.54%   81.82%   +0.28%     
==========================================
  Files        5343     5410      +67     
  Lines      142128   144322    +2194     
  Branches    32411    32962     +551     
==========================================
+ Hits       115899   118094    +2195     
+ Misses      18299    18143     -156     
- Partials     7930     8085     +155

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud

sonarqubecloud Bot commented May 14, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@samir-acle samir-acle added this pull request to the merge queue May 15, 2026
Merged via the queue into main with commit 825cbe0 May 15, 2026
63 checks passed
@samir-acle samir-acle deleted the GE-217-pre-prompt-for-push-notifications-ui-sheets branch May 15, 2026 16:01
@github-actions github-actions Bot locked and limited conversation to collaborators May 15, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.79.0 Issue or pull request that will be included in release 7.79.0 label May 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Montoya Montoya Montoya approved these changes

@baptiste-marchand baptiste-marchand baptiste-marchand approved these changes

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.79.0 Issue or pull request that will be included in release 7.79.0 size-L team-engagement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@samir-acle @codecov-commenter @Montoya @baptiste-marchand