Skip to content

chore(rewards): add total outflow when user has cashed out value#30147

Merged
sophieqgu merged 1 commit into
mainfrom
Add-Total-inflow-to-stats-page
May 14, 2026
Merged

chore(rewards): add total outflow when user has cashed out value#30147
sophieqgu merged 1 commit into
mainfrom
Add-Total-inflow-to-stats-page

Conversation

@sophieqgu

@sophieqgu sophieqgu commented May 13, 2026

Copy link
Copy Markdown
Contributor

Description

Simulator Screenshot - E2E Test  - 2026-05-13 at 16 24 11 Display total inflow value when user has cashed out from Ondo ## **Changelog**

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk UI-only change gated on totalCashedOut > 0, plus i18n string additions and test updates; no auth, network, or data-write paths are modified.

Overview
Adds a new "Total inflow" stat to OndoCampaignStatsView, displayed alongside Days held when a user has a non-zero totalCashedOut (i.e., the outflow row is shown). Uses summary.totalUsdDeposited for the value and keeps it hidden when no cash-out has occurred.

Updates the Ondo campaign stats tests to assert the new row/value and adds label_total_inflow translations across supported locales.

Reviewed by Cursor Bugbot for commit d1d4104. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sophieqgu sophieqgu marked this pull request as ready for review May 13, 2026 20:35
@metamaskbotv2 metamaskbotv2 Bot added the team-rewards Rewards team label May 13, 2026
@sophieqgu sophieqgu requested a review from a team as a code owner May 13, 2026 20:35
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
The PR makes two types of changes:

  1. OndoCampaignStatsView.tsx: Adds a new "Total inflow" stat cell to the Ondo Campaign Stats view. This is a minor, isolated UI addition within the Rewards feature. It computes totalInflowValue from portfolioData.summary.totalUsdDeposited and renders a new StatCell component when the campaign is not complete and the user has cashed out. The change is self-contained within the Rewards/Ondo Campaign feature.

  2. Locale files (16 languages): Purely additive - adds the new label_total_inflow translation key across all supported languages. No existing keys are modified.

Why no E2E tags are selected:

  • No E2E tests exist for the Ondo Campaign / Rewards feature in the available test suite
  • The changes don't touch any shared components that could break existing tests (no navigation, modals, confirmations, browser, controllers, or Engine changes)
  • The locale changes are purely additive and won't break any existing string lookups
  • None of the available E2E test tags (SmokeAccounts, SmokeConfirmations, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeSwap, SmokeStake, SmokeWalletPlatform, SmokeMoney, SmokePerps, SmokeMultiChainAPI, SmokePredictions, SmokeSeedlessOnboarding, SmokeBrowser, SmokeSnaps) cover the Rewards/Ondo Campaign functionality.

Performance Test Selection:
The changes are limited to a UI stat cell addition in the Rewards/Ondo Campaign view and locale string additions. There are no changes to rendering-heavy components, data loading pipelines, state management, account/network lists, or critical user flows that would impact measurable performance metrics.

View GitHub Actions results

@sophieqgu sophieqgu changed the title Add total outflow when user has cashed out value chore(rewards): Add total outflow when user has cashed out value May 13, 2026
@sonarqubecloud

Copy link
Copy Markdown

@sophieqgu sophieqgu changed the title chore(rewards): Add total outflow when user has cashed out value chore(rewards): add total outflow when user has cashed out value May 13, 2026
@sophieqgu sophieqgu added this pull request to the merge queue May 14, 2026
Merged via the queue into main with commit e6070d9 May 14, 2026
86 of 89 checks passed
@sophieqgu sophieqgu deleted the Add-Total-inflow-to-stats-page branch May 14, 2026 14:08
@github-actions github-actions Bot locked and limited conversation to collaborators May 14, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.78.0 Issue or pull request that will be included in release 7.78.0 label May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.78.0 Issue or pull request that will be included in release 7.78.0 size-S team-rewards Rewards team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants