ci(INFRA-3628): Phase 5b - nscloud checkout action#30139
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
cb5e998 to
bc641cd
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
Dual checkout for jobs that branch on runner_provider: check-diff, git-safe-dependencies, scripts (fetch-depth parity), js-bundle-size-check, check-workflows, ship-js-bundle-size-check, unit and component view tests, merge coverage job, smart E2E selection (sparse parity), fixture report, SonarCloud (full history parity), quality gate, and ci status gate. Co-authored-by: Cursor <cursoragent@cursor.com>
Namespace path uses nscloud-checkout-action with the same ref, fetch-depth, and submodule inputs as actions/checkout@v4 on the current path. Co-authored-by: Cursor <cursoragent@cursor.com>
Add namespacelabs/nscloud-checkout-action alongside actions/checkout for prepare, build matrix, emit-build-metadata in build.yml; first step in build-android-e2e and build-ios-e2e when runner_provider is namespace. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
… pressure Co-authored-by: Cursor <cursoragent@cursor.com>
bc641cd to
b449d9d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #30139 +/- ##
==========================================
+ Coverage 81.54% 81.79% +0.24%
==========================================
Files 5343 5393 +50
Lines 142128 143839 +1711
Branches 32411 32848 +437
==========================================
+ Hits 115899 117647 +1748
+ Misses 18299 18170 -129
- Partials 7930 8022 +92 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
These are purely additive CI infrastructure changes:
Running E2E tests would not validate these CI infrastructure changes — they would only validate app functionality which hasn't changed. No E2E test tags are warranted. Performance Test Selection: |
|



Description
Goal: Close INFRA-3628 Phase 5b — make Namespace-hosted CI jobs use Namespace’s supported checkout path instead of treating them like GitHub-hosted runners, without changing how
runner_provider: currentbehaves today.What we shipped: Every place the workflow graph already chooses Namespace via
runner_providernow checks out with nscloud checkout onnamespaceand keeps the existingactions/checkoutpath oncurrent(same majors /if:guards so the default path stays equivalent). That covers the maincigraph, reusable builds and node-modules setup, iOS/Android E2E build workflows, the callablerun-e2e-workflowrunner, and the smoke/regression report jobs that also land on Namespace Linux when trialing Namespace.E2E setup: The shared
setup-e2e-envcomposite accepts optional yarn and CocoaPods per-attempt retry timeouts;run-e2e-workflowraises the outerSet up E2E environmentcap for Namespace + iOS and passes those inputs so parallel iOS smoke is less likely to die mid-install under contention. This is a stability cushion; deeper Namespace CocoaPods cache work can follow the same ticket / INFRA-3596 thread.Scope note: No app or product behaviour changes — CI and composite action YAML only.
Changelog
CHANGELOG entry: null
Related issues
Fixes: INFRA-3628
Manual testing steps
Screenshots/Recordings
N/A — infrastructure / CI only.
Before
N/A
After
N/A
Pre-merge author checklist
pull_requestCI and Namespaceworkflow_dispatchtrials on this branch)Performance checks (if applicable)
N/A — no app or bundle changes.
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Medium Risk
Touches a broad set of CI workflows and checkout paths; while behavior is intended to be equivalent for
runner_provider: current, misconfiguredif:guards or checkout options could break builds/tests specifically on Namespace runners.Overview
Updates the CI workflow graph (main
ci.yml, reusable build workflows, E2E smoke/regression runners, andsetup-node-modules) to conditionally usenamespacelabs/nscloud-checkout-actionwhenrunner_provider == 'namespace', while keeping the existingactions/checkoutpath forcurrent.Extends the
setup-e2e-envcomposite action with new inputs for per-attempt retry timeouts (JS deps/Corepack and CocoaPods), and updatesrun-e2e-workflow.ymlto increase the overall setup timeout for Namespace+iOS and pass larger timeout values into the composite.Reviewed by Cursor Bugbot for commit d58574f. Bugbot is set up for automated code reviews on this repo. Configure here.