chore: cherry-pick feat: hoist perps providers for homepage hub tabs UI#30134
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - PR targets a release branch (release/*) All E2E tests pre-selected. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
feat: hoist perps providers for homepage hub tabs UI cp-7.77.0 #29757
Changelog
CHANGELOG entry:null
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/TMCU-737
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Medium Risk
Changes Perps stream emission control (pause is now reference-counted) and alters provider wiring across Homepage/DiscoveryTabs, which could impact live Perps data updates and tab navigation behavior if mismanaged.
Overview
Hoists
PerpsConnectionProvider/PerpsStreamProviderto wrapHomepageDiscoveryTabs, and adds aperpsProvidersHoistedoption toHomepageso it can skip re-wrapping Perps sections when a parent already provides the context.Introduces reference-counted pausing in
StreamChannel(replacing a boolean) so multiple callers can pause/resume without clobbering each other, and addsPerpsStreamManager.pauseAllChannels()/resumeAllChannels()to pause/resume all WS-backed channels.Updates Discovery Tabs to pause Perps WS channels when switching to non-Perps tabs (e.g. Predictions), resume when returning, and ensure unmount cleanup only resumes if the tab layer actually holds a pause; adds/adjusts unit tests covering these cases and Perps section rendering under the Perps feature flag.
Reviewed by Cursor Bugbot for commit 5ac8c51. Bugbot is set up for automated code reviews on this repo. Configure here.