You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Feature: my feature nameScenario: user [verb for user action]Given [describe expected initial app state]
When user [verb for user action]
Then [describe expected outcome]
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Note
Low Risk
Low risk because this only disables a smoke test; it may reduce coverage for dapp-specific network selection and transaction confirmation behavior until re-enabled.
Overview
Disables the Dapp Network Switching smoke confirmation suite by changing describe to describe.skip in per-dapp-selected-network.spec.ts, preventing the failing test from running in CI.
Reviewed by Cursor Bugbot for commit aa9a19a. Bugbot is set up for automated code reviews on this repo. Configure here.
Selected Performance tags: None (no tests recommended)
Risk Level: low
AI Confidence: 95%
click to see 🤖 AI reasoning details
E2E Test Selection:
The only change in this PR is adding .skip to the describe block in per-dapp-selected-network.spec.ts, converting describe(SmokeConfirmations('Dapp Network Switching'), ...) to describe.skip(SmokeConfirmations('Dapp Network Switching'), ...). This disables the entire "Dapp Network Switching" test suite. No application code is modified - this is purely a test file change. Running SmokeConfirmations is appropriate to: (1) verify the skip is applied correctly and doesn't cause test runner errors, and (2) confirm the remaining confirmations tests still pass unaffected. No other tags are needed since no app code, shared components, or other test areas are touched.
Performance Test Selection:
This change only skips an existing E2E test - no application code, UI components, state management, or performance-sensitive paths are modified. No performance tests are needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
no-changelogno-changelog Indicates no external facing user changes, therefore no changelog documentation neededrelease-7.78.0Issue or pull request that will be included in release 7.78.0size-XSteam-qaQA team
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Skips a failing test.
See: https://consensys.slack.com/archives/C02U025CVU4/p1778681293178909?thread_ts=1778662845.117629&cid=C02U025CVU4
Changelog
CHANGELOG entry:
Related issues
Fixes: https://consensys.slack.com/archives/C02U025CVU4/p1778681293178909?thread_ts=1778662845.117629&cid=C02U025CVU4
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Low Risk
Low risk because this only disables a smoke test; it may reduce coverage for dapp-specific network selection and transaction confirmation behavior until re-enabled.
Overview
Disables the
Dapp Network Switchingsmoke confirmation suite by changingdescribetodescribe.skipinper-dapp-selected-network.spec.ts, preventing the failing test from running in CI.Reviewed by Cursor Bugbot for commit aa9a19a. Bugbot is set up for automated code reviews on this repo. Configure here.