Description

Fixes a Predict pay-with-any-token alert flicker where a blocking pay-token alert could briefly take precedence while payment quotes/totals were still settling.

Problem:

• Predict can have a valid external payment token selected while the Transaction Pay quote state is still catching up to the latest amount.
• During that settling window, blockingPayAlertMessage could be treated as ready and suppress the active order banner / surface an insufficient-funds style message too early.
• The payment settling key also used the raw total amount, making it more sensitive than the user-facing quote amount needs to be.

Fix:

• Normalize the payment settling key amount by rounding the required quote amount up to two decimals.
• Pass isPaySystemSettling into usePredictBuyError.
• Prevent blocking pay-token alerts from taking precedence while the pay system is still settling.
• Add focused hook coverage for settling-time pay-alert suppression.

Changelog

CHANGELOG entry: Fixed a bug that caused Predict pay-with-any-token alerts to flicker while quotes were loading

Related issues

https://consensyssoftware.atlassian.net/browse/CONF-1345

Manual testing steps

Feature: Predict pay with any token

  Scenario: user changes the Predict order amount while paying with a token
    Given the user is on a Predict market buy flow
    And the user has selected a pay-with-any-token payment token
    When the user changes the order amount
    Then the pay-token alert does not flicker while the new quote is loading
    And the correct blocking alert is shown only after the quote/totals state has settled

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.