test: Migrate identity multichain E2E coverage to CV#30107
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit dbf0d13. Configure here.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #30107 +/- ##
==========================================
+ Coverage 81.54% 82.01% +0.47%
==========================================
Files 5343 5440 +97
Lines 142128 145312 +3184
Branches 32411 33253 +842
==========================================
+ Hits 115899 119184 +3285
+ Misses 18299 17990 -309
- Partials 7930 8138 +208 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@metamaskbot update-mobile-fixture |
|
🔄 Fixture update started. Running workflow from branch |
|
❌ E2E fixture update failed.\n\nCommon causes:\n- CI workflow is still running — wait for 'Build iOS Apps' to complete\n- CI workflow was skipped — ensure your PR has iOS-impacting changes or use |
1 similar comment
|
❌ E2E fixture update failed.\n\nCommon causes:\n- CI workflow is still running — wait for 'Build iOS Apps' to complete\n- CI workflow was skipped — ensure your PR has iOS-impacting changes or use |
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
Tag selection rationale:
No production code changes means risk of breaking existing E2E tests is low. Performance tests are not warranted as no UI rendering, data loading, or app startup code was modified. Performance Test Selection: |
|




Description
Summary
Migrates selected Identity + Multichain Accounts coverage from E2E toward Component View tests for the E2E -> CV effort.
This PR adds shared CV identity and multichain-account presets/renderers, plus route-probe and controller mock support, then adds CV coverage for:
AddressBookController, and opening the network selectorE2E removal
Removes:
tests/smoke/multichain-accounts/account-details.spec.tsRationale: the active Account Details rename behavior from that smoke spec is now covered directly at the CV layer through route wiring, validation, and controller interaction.
Changelog
CHANGELOG entry: null
Related issues
Fixes: MMQA-1723
Manual testing steps
Validation performed locally:
yarn jest -c jest.config.view.js app/components/Views/Settings/Identity/BackupAndSyncSettings.view.test.tsx app/components/Views/Settings/Contacts/Contacts.view.test.tsx app/component-library/components-temp/MultichainAccounts/MultichainAccountSelectorList/MultichainAccountSelectorList.view.test.tsx app/components/Views/MultichainAccounts/AccountGroupDetails/AccountGroupDetails.view.test.tsx app/components/Views/MultichainAccounts/sheets/DeleteAccount/DeleteAccount.view.test.tsx app/components/Views/MultichainAccounts/IntroModal/MultichainAccountsIntroModal.view.test.tsx app/components/Views/MultichainAccounts/PrivateKeyList/PrivateKeyList.view.test.tsx app/components/Views/MultichainAccounts/MultichainPermissionsSummary/MultichainPermissionsSummary.view.test.tsx --runInBand --silent --coverage=false- PASS, 8 suites / 70 testsScreenshots/Recordings
Before
N/A - test-only migration.
After
N/A - test-only migration.
Pre-merge author checklist
Performance checks (if applicable)
Pre-merge reviewer checklist
Note
Low Risk
Low risk: changes are confined to test code and test utilities (mocks/fixtures/render helpers), with no production behavior changes beyond how tests execute.
Overview
Adds new Component View test suites covering Identity (Backup & Sync toggles, Contacts list/form flows) and Multichain Accounts (account selector, account group details, intro/learn-more modals, permissions summary, private key list, and delete-account sheet behaviors).
Introduces shared CV infrastructure to support these suites: richer
Enginecontroller mocks, newidentity/multichainAccountsstate presets and renderers, and route/route-params probe helpers intests/component-view/render.tsxfor asserting navigation without mocking.Removes the legacy multichain account details smoke spec (
tests/smoke/multichain-accounts/account-details.spec.ts) now covered by the new CV tests.Reviewed by Cursor Bugbot for commit 2fdff6e. Bugbot is set up for automated code reviews on this repo. Configure here.