fix: wrap ConnectQRHardware in SafeAreaView#30092
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e2c137f. Configure here.
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
The impact is strictly limited to the QR Hardware Wallet connection screen. SmokeAccounts is the appropriate tag as it covers "adding QR-based hardware wallet accounts" which is exactly the flow this component supports. No other flows, controllers, or shared components are affected. No performance impact is expected from this layout refactor. Performance Test Selection: |
|
ConnectQRHardware in SafeAreaView
gantunesr
left a comment
There was a problem hiding this comment.
lgtm. Did not test
@montelaidev if possible lets add some screenshots to the PR
Description
This PR updates the the QRConnectHardware to use
SafeAreaViewChangelog
CHANGELOG entry: updates the view of the QRConnectHardware to be aware of notches and bottom screen menus.
Related issues
Fixes:
Manual testing steps
Not applicable
Screenshots/Recordings
TBD
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Low Risk
Low risk UI/layout change limited to the
ConnectQRHardwarescreen; main risk is unintended spacing on some devices due to safe-area edge configuration.Overview
Updates
ConnectQRHardwareto rely onSafeAreaViewfor notch/edge handling instead of manually applyinginsets.top, and explicitly limits safe-area padding totop/left/right.Adds
testIDs for the new safe-area container and header, and extends the test suite with safe-area-context mocks plus assertions that header top margin is removed and the container excludes the bottom edge in both instruction and account-selector states.Reviewed by Cursor Bugbot for commit b6f3016. Bugbot is set up for automated code reviews on this repo. Configure here.