fix(skills): pin *.sh to LF so scripts run in WSL#30078
Merged
Conversation
Without an explicit eol attribute, Windows clones with core.autocrlf=true rewrite shell scripts to CRLF and bash fails in WSL with `set: invalid option` and `$'\\r': command not found`. Git Bash tolerated it; WSL did not. Pinning *.sh to LF makes the checkout deterministic across platforms.
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
No E2E tests or performance tests are warranted for this change. Performance Test Selection: |
7 tasks
|
gambinish
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*.shtoeol=lfin.gitattributes.core.autocrlf=truerewritescripts/skills-sync.shto CRLF, andbashfails in WSL withset: invalid optionand$'\r': command not found. Git Bash tolerated it; WSL did not..gitattributesin Consensys/skills.Test plan
git check-attr -a scripts/skills-sync.shreportseol: lfyarn skillsruns without\rerrorsNote
Low Risk
Low risk change limited to git line-ending attributes; it only affects how
*.shfiles are checked out on Windows/WSL and should not impact runtime logic.Overview
Ensures
*.shfiles are always checked out with LF by adding*.sh text eol=lfto.gitattributes, preventing Windowsautocrlfclones from rewriting scripts to CRLF and breaking execution in WSL.Reviewed by Cursor Bugbot for commit 788deae. Bugbot is set up for automated code reviews on this repo. Configure here.