Skip to content

fix(ci): ota slack notification channel#30053

Merged
weitingsun merged 3 commits into
mainfrom
wsun/fix-ota-slack-notification-channel
May 12, 2026
Merged

fix(ci): ota slack notification channel#30053
weitingsun merged 3 commits into
mainfrom
wsun/fix-ota-slack-notification-channel

Conversation

@weitingsun

@weitingsun weitingsun commented May 12, 2026

Copy link
Copy Markdown
Contributor

Description

Runway OTA RC workflow is posting notification to the wrong slack channel. It posting to source branch channel instead of the OTA channel channel. This PR fixes this issue

Changelog

CHANGELOG entry:null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: workflow-only change that adjusts how Slack notification metadata is derived, with no impact to app runtime code. Main risk is mis-parsing branch names causing missing/incorrect Slack routing or version display.

Overview
Fixes Runway OTA RC Slack notifications by deriving the semver/channel identifier from the release branch name and passing it explicitly to slack-rc-notification.yml.

Adds a derive-slack-semver job after push-ota, and updates slack-notification to depend on it and use its semver output instead of relying on the source branch alone.

Reviewed by Cursor Bugbot for commit b1a96b4. Bugbot is set up for automated code reviews on this repo. Configure here.

@weitingsun weitingsun marked this pull request as ready for review May 12, 2026 16:34
@weitingsun weitingsun requested a review from a team as a code owner May 12, 2026 16:34
@github-actions github-actions Bot added the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label May 12, 2026
@metamaskbotv2 metamaskbotv2 Bot added the team-mobile-platform Mobile Platform team label May 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@weitingsun weitingsun enabled auto-merge May 12, 2026 17:31
@sonarqubecloud

Copy link
Copy Markdown

@weitingsun weitingsun added this pull request to the merge queue May 12, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 12, 2026
@weitingsun weitingsun added this pull request to the merge queue May 12, 2026
Merged via the queue into main with commit 4615aa4 May 12, 2026
60 of 62 checks passed
@weitingsun weitingsun deleted the wsun/fix-ota-slack-notification-channel branch May 12, 2026 19:10
@github-actions github-actions Bot locked and limited conversation to collaborators May 12, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.78.0 Issue or pull request that will be included in release 7.78.0 label May 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. release-7.78.0 Issue or pull request that will be included in release 7.78.0 size-S team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants