Skip to content

chore(runway): cherry-pick fix: skip useInsufficientNativeReserveError if non evm cp-7.77.0#30048

Merged
chloeYue merged 1 commit into
release/7.77.0from
runway-cherry-pick-7.77.0-1778598138
May 12, 2026
Merged

chore(runway): cherry-pick fix: skip useInsufficientNativeReserveError if non evm cp-7.77.0#30048
chloeYue merged 1 commit into
release/7.77.0from
runway-cherry-pick-7.77.0-1778598138

Conversation

@runway-github

@runway-github runway-github Bot commented May 12, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes an issue introduced by
#29712, where the app
would crash if a user tries to get a non-EVM swap quote. The fix was to
skip useInsufficientNativeReserveError if it is a non-EVM network.

Changelog

CHANGELOG entry: Fixed app crashing when trying to get a Swaps quote for
non-EVM networks

Related issues

Fixes: #29987

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Screen.Recording.2026-05-11.at.12.15.57.PM.mov

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
  • Use these power-user
    SRPs

    to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production
    performance metrics
  • See trace() for usage and
    addToken
    for an example

For performance guidelines and tooling, see the Performance
Guide
.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Low Risk
Low risk guard change that prevents running EVM-only reserve logic on
non-EVM chain IDs; main risk is accidentally suppressing the warning on
chains that should still be checked.

Overview
Prevents crashes when requesting swap/bridge quotes on non-EVM
networks by short-circuiting useInsufficientNativeReserveError when
token.chainId is non-EVM.

Adds regression coverage ensuring the native-reserve warning is not
shown for Solana swaps, and extends the hook tests to assert it returns
undefined for multiple non-EVM native tokens (Solana/Bitcoin/Tron).
Also updates the hook test store setup to use legacy_createStore.

Reviewed by Cursor Bugbot for commit
a00c033. Bugbot is set up for automated
code reviews on this repo. Configure
here.

[662560f](https://github.com/MetaMask/metamask-mobile/commit/662560f574c7f14e110c9a5e5c243291588fcfac)

…r if non evm cp-7.77.0 (#29992)

<!--
Please submit this PR as a draft initially.

Do not mark it as "Ready for review" until this PR meets the canonical
Definition of Ready For Review in `docs/readme/ready-for-review.md`.

In short: the template must be materially complete (not just section
titles
present), all status checks must be currently passing, and the only
expected
follow-up commits must be reviewer-driven.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

Fixes an issue introduced by
#29712, where the app
would crash if a user tries to get a non-EVM swap quote. The fix was to
skip `useInsufficientNativeReserveError` if it is a non-EVM network.

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: Fixed app crashing when trying to get a Swaps quote for
non-EVM networks

## **Related issues**

Fixes: #29987

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->


https://github.com/user-attachments/assets/71ac2a8b-dcce-4015-a4c2-9ba02d719421



## **Pre-merge author checklist**

<!--
Every checklist item must be consciously assessed before marking this PR
as
"Ready for review". A checked box means you deliberately considered that
responsibility, not that you literally performed every action listed.

Unchecked boxes are ambiguous: they are not an implicit "N/A" and they
are not
a silent "skip". See `docs/readme/ready-for-review.md` for the full
checklist
semantics.
-->

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

#### Performance checks (if applicable)

- [ ] I've tested on Android
  - Ideally on a mid-range device; emulator is acceptable
- [ ] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example

For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).

## **Pre-merge reviewer checklist**

<!--
Reviewer checklist items follow the same semantics as the author
checklist: an
unchecked box is ambiguous, a checked box means the reviewer consciously
assessed that responsibility. See `docs/readme/ready-for-review.md`.
-->

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Low risk guard change that prevents running EVM-only reserve logic on
non-EVM chain IDs; main risk is accidentally suppressing the warning on
chains that should still be checked.
> 
> **Overview**
> Prevents crashes when requesting swap/bridge quotes on non-EVM
networks by short-circuiting `useInsufficientNativeReserveError` when
`token.chainId` is non-EVM.
> 
> Adds regression coverage ensuring the native-reserve warning is not
shown for Solana swaps, and extends the hook tests to assert it returns
`undefined` for multiple non-EVM native tokens (Solana/Bitcoin/Tron).
Also updates the hook test store setup to use `legacy_createStore`.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
a00c033. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@runway-github runway-github Bot requested a review from a team as a code owner May 12, 2026 15:02
@runway-github runway-github Bot force-pushed the runway-cherry-pick-7.77.0-1778598138 branch from 4393a2b to 30f1a3e Compare May 12, 2026 15:02
@metamaskbotv2 metamaskbotv2 Bot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label May 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - PR targets a release branch (release/*)

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@chloeYue chloeYue merged commit 9573a84 into release/7.77.0 May 12, 2026
177 of 179 checks passed
@chloeYue chloeYue deleted the runway-cherry-pick-7.77.0-1778598138 branch May 12, 2026 17:46
@github-actions github-actions Bot locked and limited conversation to collaborators May 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size-S team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants